From: Jason Wang <jasowang@redhat.com>
To: Zhi Yong Wu <zwu.kernel@gmail.com>, netdev@vger.kernel.org
Cc: therbert@google.com, Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Subject: Re: [net-next bugfix] tun, rfs: fix the incorrect hash value
Date: Thu, 02 Jan 2014 13:41:56 +0800 [thread overview]
Message-ID: <52C4FC24.6060805@redhat.com> (raw)
In-Reply-To: <1388640268-25575-1-git-send-email-zwu.kernel@gmail.com>
On 01/02/2014 01:24 PM, Zhi Yong Wu wrote:
> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>
> The code incorrectly save the queue index as the hash, so this patch
> is fixing it with the hash received in the stack receive path.
>
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> ---
> drivers/net/tun.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
> index 3cf0457..09f6662 100644
> --- a/drivers/net/tun.c
> +++ b/drivers/net/tun.c
> @@ -378,8 +378,8 @@ static u16 tun_select_queue(struct net_device *dev, struct sk_buff *skb)
> if (txq) {
> e = tun_flow_find(&tun->flows[tun_hashfn(txq)], txq);
> if (e) {
> - txq = e->queue_index;
> tun_flow_save_rps_rxhash(e, txq);
> + txq = e->queue_index;
> } else
> /* use multiply and shift instead of expensive divide */
> txq = ((u64)txq * numqueues) >> 32;
Acked-by: Jason Wang <jasowang@redhat.com>
next prev parent reply other threads:[~2014-01-02 5:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 5:24 [net-next bugfix] tun, rfs: fix the incorrect hash value Zhi Yong Wu
2014-01-02 5:41 ` Jason Wang [this message]
2014-01-02 7:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C4FC24.6060805@redhat.com \
--to=jasowang@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=wuzhy@linux.vnet.ibm.com \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).