From: Ding Tianhong <dingtianhong@huawei.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Joe Perches <joe@perches.com>, Jay Vosburgh <fubar@us.ibm.com>,
Veaceslav Falico <vfalico@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND net-next 1/7] bonding: use ether_addr_equal_unaligned for bond addr compare
Date: Thu, 2 Jan 2014 17:00:29 +0800 [thread overview]
Message-ID: <52C52AAD.8040603@huawei.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1401020937490.2182@localhost6.localdomain6>
On 2014/1/2 16:38, Julia Lawall wrote:
> On Thu, 2 Jan 2014, Ding Tianhong wrote:
>
>> On 2014/1/2 15:39, Julia Lawall wrote:
>>> Are the casts needed
>>
>>
>> Yes, otherwise the warming will report:
>>
>> /net-next/drivers/net/bonding/bond_3ad.c:427: warning: passing argument 1 of ‘ether_addr_equal_64bits’ from incompatible pointer type
>
> Is it necessary for this driver to use a different type from everyone
> else?
>
> julia
>
Did you mean the MAC_ADDRESS_EQUAL is excess?
I did not remove it because the codes no need to be changed more and it looks that didn't take any negative effect.
Regards
Ding
next prev parent reply other threads:[~2014-01-02 9:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 1:12 [PATCH RESEND net-next 1/7] bonding: use ether_addr_equal_unaligned for bond addr compare Ding Tianhong
2014-01-02 7:39 ` Julia Lawall
2014-01-02 8:21 ` Ding Tianhong
2014-01-02 8:38 ` Julia Lawall
2014-01-02 9:00 ` Ding Tianhong [this message]
2014-01-02 9:14 ` Julia Lawall
2014-01-02 10:26 ` Ding Tianhong
2014-01-02 10:38 ` Ding Tianhong
2014-01-02 10:42 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C52AAD.8040603@huawei.com \
--to=dingtianhong@huawei.com \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).