netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Or Gerlitz <ogerlitz@mellanox.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: inconsistency of ethtool feature names for get vs. set
Date: Thu, 2 Jan 2014 11:47:37 +0200	[thread overview]
Message-ID: <52C535B9.7080208@mellanox.com> (raw)

Hi Ben,

I noticed some inconsistency of feature names with the ethtool 
getting/setting of features mechanics -- the name of the feature you 
need to set (through -K) isn't what displayed by the get (-k) directive, 
here's an example:

$ ethtool -k eth1  | grep generic-receive-offload
generic-receive-offload: on

$ ethtool -K eth1  generic-receive-offload off
ethtool: bad command line argument(s)
For more information run ethtool -h

--> looking in the sources and realizing I need to use "rx-gro"

$ ethtool -K eth1  rx-gro on

$ethtool -k eth1  | grep generic-receive-offload
generic-receive-offload: on

same problem for rx checksum which is displayed as "rx-checksumming" by 
the get (-k)
but need to be "rx-checksum" for the set (-K) directive.

Basically, this can be resolved by fairly simple patch, but I wasn't 
sure if you want it in user space, in the kernel or both...

Or.

             reply	other threads:[~2014-01-02  9:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-02  9:47 Or Gerlitz [this message]
2014-01-02 12:40 ` inconsistency of ethtool feature names for get vs. set Rami Rosen
2014-01-02 15:03 ` Ben Hutchings
2014-01-02 18:41   ` Ben Hutchings
2014-01-02 20:12     ` Or Gerlitz
2014-01-06 20:39       ` Ben Hutchings
2014-01-07  4:58     ` Bill Fink
2014-05-29 14:40       ` Spike White
2014-05-30  2:39         ` Bill Fink

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52C535B9.7080208@mellanox.com \
    --to=ogerlitz@mellanox.com \
    --cc=bhutchings@solarflare.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).