From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ding Tianhong Subject: Re: [PATCH RESEND net-next 1/7] bonding: use ether_addr_equal_unaligned for bond addr compare Date: Thu, 2 Jan 2014 18:26:14 +0800 Message-ID: <52C53EC6.30902@huawei.com> References: <52C4BD16.5010702@huawei.com> <52C52180.2030707@huawei.com> <52C52AAD.8040603@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Joe Perches , Jay Vosburgh , Veaceslav Falico , "David S. Miller" , Netdev , "linux-kernel@vger.kernel.org" To: Julia Lawall Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 2014/1/2 17:14, Julia Lawall wrote: > On Thu, 2 Jan 2014, Ding Tianhong wrote: >=20 >> On 2014/1/2 16:38, Julia Lawall wrote: >>> On Thu, 2 Jan 2014, Ding Tianhong wrote: >>> >>>> On 2014/1/2 15:39, Julia Lawall wrote: >>>>> Are the casts needed >>>> >>>> >>>> Yes, otherwise the warming will report: >>>> >>>> /net-next/drivers/net/bonding/bond_3ad.c:427: warning: passing arg= ument 1 of =E2=80=98ether_addr_equal_64bits=E2=80=99 from incompatible = pointer type >>> >>> Is it necessary for this driver to use a different type from everyo= ne=20 >>> else? >>> >>> julia >>> >> Did you mean the MAC_ADDRESS_EQUAL is excess? >> I did not remove it because the codes no need to be changed more and= it looks that didn't take any negative effect. >=20 > No, I was wondering about the mac_addr type, defined in bond_3ad.h. = Other=20 > code just has the array inlined into the containing structure. >=20 > julia >=20 Oh, sorry for mismatch.:) The code for bond_3ad mode is too old and the use for mac addr is not s= o comfortable. I think I need to send a patch to fix the unusual mac addr and make it = more reasonable. Thanks for your opinion. Regards Ding=20