From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 4/6] phy: kill excess code
Date: Sun, 05 Jan 2014 03:50:30 +0300 [thread overview]
Message-ID: <52C8AC56.7030804@cogentembedded.com> (raw)
In-Reply-To: <20140104155114.GF4925@netboy>
Hello.
On 01/04/2014 06:51 PM, Richard Cochran wrote:
>>>> Both kinds of empty lines are consistently avoided by all other
>>>> code I had to read. They don't really improve anything.
>>> But both your subject line and body talk about lines of code. Just
>>> removing blank lines is not the same as removing "excess code."
>> To me, all source file lines are code. So what you are
>> suggesting, splitting the patch?
> Yes, exactly that.
OK, done.
> If the title reads, "fix whitespace errors" or "remove blank lines",
> then I don't need to waste my time looking at it.
Maybe I'd go too far and remove too much? :-)
> But if it reads, "remove excess code", then I want to make sure that
> you don't go and delete something important.
I don't delete the meaningful code at all, just kind of compact it. Maybe
I should have renamed that patch...
> Thanks,
> Richard
WBR, Sergei
next prev parent reply other threads:[~2014-01-04 23:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-04 1:13 [PATCH 0/6] phylib: cleanups Sergei Shtylyov
2014-01-04 1:14 ` [PATCH 1/6] phy: coding style fixes Sergei Shtylyov
2014-01-04 1:16 ` [PATCH 2/6] mdio_bus: " Sergei Shtylyov
2014-01-04 1:17 ` [PATCH 3/6] phy: kill useless local variables Sergei Shtylyov
2014-01-04 7:34 ` Richard Cochran
2014-01-04 1:19 ` [PATCH 4/6] phy: kill excess code Sergei Shtylyov
2014-01-04 7:36 ` Richard Cochran
2014-01-04 16:29 ` Sergei Shtylyov
2014-01-04 15:42 ` Richard Cochran
2014-01-04 16:47 ` Sergei Shtylyov
2014-01-04 15:51 ` Richard Cochran
2014-01-05 0:50 ` Sergei Shtylyov [this message]
[not found] ` <CAGVrzcadLFE-FWvgDQE5gkd6COZkGs2Q4SQdnOdKE4Deu-qa0A@mail.gmail.com>
2014-01-04 16:24 ` Sergei Shtylyov
2014-01-04 1:21 ` [PATCH 5/6] phylib: remove unused adjust_state callback Sergei Shtylyov
2014-01-04 1:23 ` [PATCH 6/6] phylib: make phy_scan_fixups() static Sergei Shtylyov
2014-01-05 0:07 ` Sergei Shtylyov
2014-01-04 1:28 ` [PATCH 0/6] phylib: cleanups Sergei Shtylyov
2014-01-04 15:53 ` Richard Cochran
2014-01-04 17:14 ` Sergei Shtylyov
2014-01-04 18:53 ` Sergei Shtylyov
2014-01-05 8:31 ` Richard Cochran
2014-01-05 13:40 ` Sergei Shtylyov
2014-01-06 8:35 ` Richard Cochran
2014-01-04 16:41 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C8AC56.7030804@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).