From: Guenter Roeck <linux@roeck-us.net>
To: David Miller <davem@davemloft.net>
Cc: isdn@linux-pingi.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] isdn: Mark build for telespci and hfc_pci as broken for big endian ARM
Date: Sun, 05 Jan 2014 20:25:41 -0800 [thread overview]
Message-ID: <52CA3045.80807@roeck-us.net> (raw)
In-Reply-To: <20140105.203959.962622308205839285.davem@davemloft.net>
On 01/05/2014 05:39 PM, David Miller wrote:
> From: Guenter Roeck <linux@roeck-us.net>
> Date: Sun, 5 Jan 2014 11:49:27 -0800
>
>> With arm:allmodconfig, building the Teles PCI driver fails with
>>
>> telespci.c:294:2: error: #error "not running on big endian machines now"
>>
>> Similar, building the driver for HFC PCI-Bus cards fails with
>>
>> hfc_pci.c:1647:2: error: #error "not running on big endian machines now"
>>
>> Mark build as broken for big endian ARM machines.
>>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Let's not start getting into the habit of doing this, please.
>
> The reason this isn't easy to do generically from Kconfig is
> probably because it almost never makes any sense to do so.
>
> In fact, if you look at telespci.c there are no DMA descriptors,
> everything is read using MMIO acccesses via the chips FIFO. There
> really can't be any endianness problems that I see.
>
> Please just remove the CPP checks, that's the best fix.
>
Both drivers build with arm:allmodconfig if I remove the check,
so I am fine with that. I'll send an updated patch.
Thanks,
Guenter
prev parent reply other threads:[~2014-01-06 4:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-05 19:49 [PATCH v2] isdn: Mark build for telespci and hfc_pci as broken for big endian ARM Guenter Roeck
2014-01-06 1:39 ` David Miller
2014-01-06 4:25 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CA3045.80807@roeck-us.net \
--to=linux@roeck-us.net \
--cc=davem@davemloft.net \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).