netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Duyck <alexander.h.duyck@intel.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
	donald.c.skidmore@intel.com, e1000-devel@lists.sourceforge.net,
	netdev@vger.kernel.org
Subject: Re: question about ixgbevf/ixgbevf_main.c
Date: Tue, 07 Jan 2014 07:42:30 -0800	[thread overview]
Message-ID: <52CC2066.1030303@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1401071542370.2094@hadrien>

A VF isn't a real device so it shouldn't really have the concept of a
power state.  The power state for the device is controlled via the PF.
I suspect the fact that ixgbevf is modifying power state on resume is
likely a bug.

Thanks,

Alex

On 01/07/2014 06:46 AM, Julia Lawall wrote:
> I was wondering why ixgbevf_suspend doesn't call pci_set_power_state?  It
> is called in the corresponding resume function, and most other PCI drivers
> with a suspend functyion also call it in suspend.
> 
> thanks,
> julia
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2014-01-07 15:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-07 14:46 question about ixgbevf/ixgbevf_main.c Julia Lawall
2014-01-07 15:42 ` Alexander Duyck [this message]
2014-01-07 15:44   ` Julia Lawall
2014-01-07 15:55     ` Alexander Duyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CC2066.1030303@intel.com \
    --to=alexander.h.duyck@intel.com \
    --cc=donald.c.skidmore@intel.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=julia.lawall@lip6.fr \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).