From: Alexander Duyck <alexander.h.duyck@intel.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: donald.c.skidmore@intel.com, e1000-devel@lists.sourceforge.net,
netdev@vger.kernel.org
Subject: Re: question about ixgbevf/ixgbevf_main.c
Date: Tue, 07 Jan 2014 07:55:15 -0800 [thread overview]
Message-ID: <52CC2363.1030402@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1401071643340.2094@hadrien>
On 01/07/2014 07:44 AM, Julia Lawall wrote:
> On Tue, 7 Jan 2014, Alexander Duyck wrote:
>
>> A VF isn't a real device so it shouldn't really have the concept of a
>> power state. The power state for the device is controlled via the PF.
>> I suspect the fact that ixgbevf is modifying power state on resume is
>> likely a bug.
> Thanks for the information, which is very helpful. Should I submit a
> patch to remove it in the resume function? I don't have the ability ot
> test it, though.
>
> julia
>
You could submit a patch. The issue should just be cosmetic. Setting
the power state to D0 should have no impact on things one way or another
since that is the state VFs are normally in when they are created.
Thanks,
Alex
prev parent reply other threads:[~2014-01-07 15:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 14:46 question about ixgbevf/ixgbevf_main.c Julia Lawall
2014-01-07 15:42 ` Alexander Duyck
2014-01-07 15:44 ` Julia Lawall
2014-01-07 15:55 ` Alexander Duyck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CC2363.1030402@intel.com \
--to=alexander.h.duyck@intel.com \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=julia.lawall@lip6.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).