From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Alban Crequy <alban.crequy@collabora.co.uk>,
Andrew Collins <bsderandrew@gmail.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Brad Johnson <bjohnson@ecessa.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: Possible to add netfilter hooks to IFB driver?
Date: Wed, 08 Jan 2014 07:28:44 -0500 [thread overview]
Message-ID: <52CD447C.4080708@mojatatu.com> (raw)
In-Reply-To: <20140107111807.38624f74@rainbow.cbg.collabora.co.uk>
On 01/07/14 06:18, Alban Crequy wrote:
> On Mon, 6 Jan 2014 15:51:37 -0700
> Andrew Collins <bsderandrew@gmail.com> wrote:
>
>> On Mon, Jan 6, 2014 at 2:51 PM, Stephen Hemminger
>> <stephen@networkplumber.org> wrote:
>>>
>>> The risk is creating the same races that made IMQ unacceptable.
>>> --
>>
>> I believe openwrt nowadays uses a TC action which runs the packet
>> through prerouting then pulls in the mark off the ct entry into the
>> skb, so ingress+IFB can take action on it.
>
> Thanks for the info. I guess the implementation is this one:
>
> https://dev.openwrt.org/browser/trunk/target/linux/generic/patches-3.12/621-sched_act_connmark.patch
> https://dev.openwrt.org/browser/trunk/package/network/utils/iproute2/patches/210-add-act_connmark.patch
> https://dev.openwrt.org/browser/trunk/package/network/config/qos-scripts/files/usr/lib/qos/generate.sh#L343
>
>> Perhaps a cleaned up version of this would be suitable for upstream?
>
> I don't know but this seems a useful feature to me.
>
I like that approach - discussion was had here on netdev
about a year ago refer to:
http://marc.info/?t=135591832200007&r=1&w=2
since it is a long thread, jump to here:
http://marc.info/?l=linux-netdev&m=135634890120552&w=2
I believe Pablo brought it up at the last netfilter meeting
and there was no disagreement to get it going.
I dont know if kids still use these expressions - but send him
some virtual beer and he may return the love.
cheers,
jamal
prev parent reply other threads:[~2014-01-08 12:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 21:26 Possible to add netfilter hooks to IFB driver? Brad Johnson
2014-01-06 17:18 ` Alban Crequy
2014-01-06 21:51 ` Stephen Hemminger
2014-01-06 22:51 ` Andrew Collins
2014-01-07 11:18 ` Alban Crequy
2014-01-08 12:28 ` Jamal Hadi Salim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CD447C.4080708@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=alban.crequy@collabora.co.uk \
--cc=bjohnson@ecessa.com \
--cc=bsderandrew@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).