netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>, davem@davemloft.net
Cc: Greg Rose <gregory.v.rose@intel.com>,
	netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
	Mitch Williams <mitch.a.williams@intel.com>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [net-next 05/15] i40e: add a comment on barrier and fix panic on reset
Date: Thu, 09 Jan 2014 18:42:00 +0400	[thread overview]
Message-ID: <52CEB538.50505@cogentembedded.com> (raw)
In-Reply-To: <1389271944-26227-6-git-send-email-jeffrey.t.kirsher@intel.com>

Hello.

On 09-01-2014 16:52, Jeff Kirsher wrote:

> From: Greg Rose <gregory.v.rose@intel.com>

> The memory barrier used in maybe_stop_tx can use a comment.

> Also add checks to VSI->rx_rings to ensure a kernel panic is not induced.

    Don't see why this is made in one patch instead of two since the two 
things look completely unrelated and even modifying different files.

> Change-ID: I48cc1bf1d6cf301818155b737edeef77c0d790c7
> Change-ID: I1363a8445fbf521a26267849966296ed55f43ad8

    Why even 2 of them?

> Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
> Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Tested-by: Kavindya Deegala <kavindya.s.deegala@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

WBR, Sergei

  reply	other threads:[~2014-01-09 14:41 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-09 12:52 [net-next 00/15][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2014-01-09 12:52 ` [net-next 01/15] i40e: Re-enable interrupt on ICR0 Jeff Kirsher
2014-01-09 12:52 ` [net-next 02/15] i40e: use kernel specific defines Jeff Kirsher
2014-01-09 12:52 ` [net-next 03/15] i40e: Fix GPL header Jeff Kirsher
2014-01-09 12:52 ` [net-next 04/15] i40e: Fix MAC format in Write MAC address AQ cmd Jeff Kirsher
2014-01-09 12:52 ` [net-next 05/15] i40e: add a comment on barrier and fix panic on reset Jeff Kirsher
2014-01-09 14:42   ` Sergei Shtylyov [this message]
2014-01-09 17:17     ` Greg Rose
2014-01-09 20:12       ` David Miller
2014-01-09 20:14         ` Rose, Gregory V
2014-01-09 21:21         ` Ben Hutchings
2014-01-09 21:23           ` Ben Hutchings
2014-01-09 21:56             ` David Miller
2014-01-09 22:16   ` Scott Feldman
2014-01-10 17:34     ` Williams, Mitch A
2014-01-09 12:52 ` [net-next 06/15] i40e: disable packet split Jeff Kirsher
2014-01-09 12:52 ` [net-next 07/15] i40e: Cleanup reconfig rss path Jeff Kirsher
2014-01-09 12:52 ` [net-next 08/15] i40e: release NVM resource reservation on startup Jeff Kirsher
2014-01-09 12:52 ` [net-next 09/15] i40e: remove interrupt on AQ error Jeff Kirsher
2014-01-09 12:52 ` [net-next 10/15] i40e: accept pf to pf adminq messages Jeff Kirsher
2014-01-09 12:52 ` [net-next 11/15] i40e: shorten wordy fields Jeff Kirsher
2014-01-09 12:52 ` [net-next 12/15] i40e: trivial: formatting and checkpatch fixes Jeff Kirsher
2014-01-09 12:52 ` [net-next 13/15] i40e: fix spelling errors Jeff Kirsher
2014-01-09 12:52 ` [net-next 14/15] i40e: Add a dummy packet template Jeff Kirsher
2014-01-09 12:52 ` [net-next 15/15] i40e: Turn flow director off in MFP mode Jeff Kirsher
2014-01-09 20:13 ` [net-next 00/15][pull request] Intel Wired LAN Driver Updates David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CEB538.50505@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=davem@davemloft.net \
    --cc=gospo@redhat.com \
    --cc=gregory.v.rose@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=mitch.a.williams@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).