From: Daniel Borkmann <dborkman@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Cong Wang <cwang@twopensource.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: vxlan: when lower dev unregisters remove vxlan dev as well
Date: Fri, 10 Jan 2014 20:16:48 +0100 [thread overview]
Message-ID: <52D04720.5070408@redhat.com> (raw)
In-Reply-To: <20140110111233.3364ec17@nehalam.linuxnetplumber.net>
On 01/10/2014 08:12 PM, Stephen Hemminger wrote:
> On Fri, 10 Jan 2014 20:07:12 +0100
> Daniel Borkmann <dborkman@redhat.com> wrote:
>
>>>> + BUG_ON(!rtnl_is_locked());
>>>
>>>
>>> This is not necessary at all, it is known that netdev notication
>>> holds rtnl lock.
>>
>> We're not in fast-path, and if someone would call that function outside
>> of the notifier chain, it might be good to check if the lock was taken,
>> but if there's a strong opinion to not have that, I'll just remove it
>
> First, the standard way to do this is ASSERT_RTNL()
>
> Second, it is unnecessary. The function is local, only called through
> notifier and notifiers always have RTNL held.
Ok, I'll just remove it, and resend if you're fine with this.
next prev parent reply other threads:[~2014-01-10 19:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 13:01 [PATCH net-next] net: vxlan: when lower dev unregisters remove vxlan dev as well Daniel Borkmann
2014-01-10 18:51 ` Cong Wang
2014-01-10 19:07 ` Daniel Borkmann
2014-01-10 19:12 ` Stephen Hemminger
2014-01-10 19:16 ` Daniel Borkmann [this message]
2014-01-10 19:16 ` Daniel Borkmann
2014-01-10 19:10 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D04720.5070408@redhat.com \
--to=dborkman@redhat.com \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).