* [PATCH 1/1] drivers: net: silence compiler warning in smc91x.c
@ 2014-01-10 3:04 Pankaj Dubey
2014-01-10 20:42 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Pankaj Dubey @ 2014-01-10 3:04 UTC (permalink / raw)
To: linux-samsung-soc, linux-arm-kernel
Cc: Pankaj Dubey, David S. Miller, Jingoo Han, netdev
If used 64 bit compiler GCC warns that:
drivers/net/ethernet/smsc/smc91x.c:1897:7:
warning: cast from pointer to integer of different
size [-Wpointer-to-int-cast]
This patch fixes this by changing typecase from "unsigned int" to "unsigned long"
CC: "David S. Miller" <davem@davemloft.net>
CC: Jingoo Han <jg1.han@samsung.com>
CC: netdev@vger.kernel.org
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
drivers/net/ethernet/smsc/smc91x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
index 0c9b5d9..42e79b4 100644
--- a/drivers/net/ethernet/smsc/smc91x.c
+++ b/drivers/net/ethernet/smsc/smc91x.c
@@ -1894,7 +1894,7 @@ static int smc_probe(struct net_device *dev, void __iomem *ioaddr,
SMC_SELECT_BANK(lp, 1);
val = SMC_GET_BASE(lp);
val = ((val & 0x1F00) >> 3) << SMC_IO_SHIFT;
- if (((unsigned int)ioaddr & (0x3e0 << SMC_IO_SHIFT)) != val) {
+ if (((unsigned long)ioaddr & (0x3e0 << SMC_IO_SHIFT)) != val) {
netdev_warn(dev, "%s: IOADDR %p doesn't match configuration (%x).\n",
CARDNAME, ioaddr, val);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] drivers: net: silence compiler warning in smc91x.c
2014-01-10 3:04 [PATCH 1/1] drivers: net: silence compiler warning in smc91x.c Pankaj Dubey
@ 2014-01-10 20:42 ` Sergei Shtylyov
2014-01-13 19:54 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2014-01-10 20:42 UTC (permalink / raw)
To: Pankaj Dubey, linux-samsung-soc, linux-arm-kernel
Cc: David S. Miller, Jingoo Han, netdev
Hello.
On 01/10/2014 06:04 AM, Pankaj Dubey wrote:
> If used 64 bit compiler GCC warns that:
> drivers/net/ethernet/smsc/smc91x.c:1897:7:
> warning: cast from pointer to integer of different
> size [-Wpointer-to-int-cast]
> This patch fixes this by changing typecase from "unsigned int" to "unsigned long"
Only "typecast".
> CC: "David S. Miller" <davem@davemloft.net>
> CC: Jingoo Han <jg1.han@samsung.com>
> CC: netdev@vger.kernel.org
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] drivers: net: silence compiler warning in smc91x.c
2014-01-10 20:42 ` Sergei Shtylyov
@ 2014-01-13 19:54 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2014-01-13 19:54 UTC (permalink / raw)
To: sergei.shtylyov
Cc: pankaj.dubey, linux-samsung-soc, linux-arm-kernel, jg1.han,
netdev
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Fri, 10 Jan 2014 23:42:41 +0300
> Hello.
>
> On 01/10/2014 06:04 AM, Pankaj Dubey wrote:
>
>> If used 64 bit compiler GCC warns that:
>
>> drivers/net/ethernet/smsc/smc91x.c:1897:7:
>> warning: cast from pointer to integer of different
>> size [-Wpointer-to-int-cast]
>
>> This patch fixes this by changing typecase from "unsigned int" to
>> "unsigned long"
>
> Only "typecast".
Applied with this typo fixed, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-13 19:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-10 3:04 [PATCH 1/1] drivers: net: silence compiler warning in smc91x.c Pankaj Dubey
2014-01-10 20:42 ` Sergei Shtylyov
2014-01-13 19:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).