* [PATCH net-next 1/2] net: qlcnic: fix warning for incorrect type in argument
@ 2014-01-11 8:23 Ding Tianhong
2014-01-14 7:31 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ding Tianhong @ 2014-01-11 8:23 UTC (permalink / raw)
To: Himanshu Madhani, Rajesh Borundia, David S. Miller, Netdev,
Joe Perches, Julia Lawall
The commit 6878f79a8b71e8c7b0587a1185584f54fd31f185
(net: qlcnic: slight optimization of addr compare)
cause a warning "sparse: incorrect type in argument 2
(different type sizes)", so fix it.
I think julia will convert ether_addr_equal to ether_addr_equal_64bits later.
Cc: Himanshu Madhani <himanshu.madhani@qlogic.com>
Cc: Rajesh Borundia <rajesh.borundia@qlogic.com>
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
index 6373f60..24714de 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
@@ -346,7 +346,7 @@ static void qlcnic_send_filter(struct qlcnic_adapter *adapter,
head = &(adapter->fhash.fhead[hindex]);
hlist_for_each_entry_safe(tmp_fil, n, head, fnode) {
- if (ether_addr_equal(tmp_fil->faddr, &src_addr) &&
+ if (ether_addr_equal(tmp_fil->faddr, (u8 *)&src_addr) &&
tmp_fil->vlan_id == vlan_id) {
if (jiffies > (QLCNIC_READD_AGE * HZ + tmp_fil->ftime))
qlcnic_change_filter(adapter, &src_addr,
--
1.8.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next 1/2] net: qlcnic: fix warning for incorrect type in argument
2014-01-11 8:23 [PATCH net-next 1/2] net: qlcnic: fix warning for incorrect type in argument Ding Tianhong
@ 2014-01-14 7:31 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-01-14 7:31 UTC (permalink / raw)
To: dingtianhong; +Cc: himanshu.madhani, rajesh.borundia, netdev, joe, julia.lawall
From: Ding Tianhong <dingtianhong@huawei.com>
Date: Sat, 11 Jan 2014 16:23:35 +0800
> The commit 6878f79a8b71e8c7b0587a1185584f54fd31f185
> (net: qlcnic: slight optimization of addr compare)
> cause a warning "sparse: incorrect type in argument 2
> (different type sizes)", so fix it.
>
> I think julia will convert ether_addr_equal to ether_addr_equal_64bits later.
>
> Cc: Himanshu Madhani <himanshu.madhani@qlogic.com>
> Cc: Rajesh Borundia <rajesh.borundia@qlogic.com>
> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-14 7:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-11 8:23 [PATCH net-next 1/2] net: qlcnic: fix warning for incorrect type in argument Ding Tianhong
2014-01-14 7:31 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).