* [PATCH net-next 2/2] net: 3com: fix warning for incorrect type in argument
@ 2014-01-11 8:23 Ding Tianhong
2014-01-14 7:31 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ding Tianhong @ 2014-01-11 8:23 UTC (permalink / raw)
To: David S. Miller, Netdev, Joe Perches, Julia Lawall
The commit c466a9b2b329f7d9982c14eedc83a923d3bc711c
(net: 3com: slight optimization of addr compare)
cause a warning: "passing argument 1 of 'ether_addr_equal'
from incompatible pointer type", so fix it.
I think julia will convert ether_addr_equal to ether_addr_equal_64bits later.
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
---
drivers/net/ethernet/3com/3c509.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/3com/3c509.c b/drivers/net/ethernet/3com/3c509.c
index 9142b47..c53384d 100644
--- a/drivers/net/ethernet/3com/3c509.c
+++ b/drivers/net/ethernet/3com/3c509.c
@@ -252,7 +252,7 @@ static int el3_isa_id_sequence(__be16 *phys_addr)
for (i = 0; i < el3_cards; i++) {
struct el3_private *lp = netdev_priv(el3_devs[i]);
if (lp->type == EL3_PNP &&
- ether_addr_equal(phys_addr, el3_devs[i]->dev_addr)) {
+ ether_addr_equal((u8 *)phys_addr, el3_devs[i]->dev_addr)) {
if (el3_debug > 3)
pr_debug("3c509 with address %02x %02x %02x %02x %02x %02x was found by ISAPnP\n",
phys_addr[0] & 0xff, phys_addr[0] >> 8,
--
1.8.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next 2/2] net: 3com: fix warning for incorrect type in argument
2014-01-11 8:23 [PATCH net-next 2/2] net: 3com: fix warning for incorrect type in argument Ding Tianhong
@ 2014-01-14 7:31 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-01-14 7:31 UTC (permalink / raw)
To: dingtianhong; +Cc: netdev, joe, julia.lawall
From: Ding Tianhong <dingtianhong@huawei.com>
Date: Sat, 11 Jan 2014 16:23:37 +0800
> The commit c466a9b2b329f7d9982c14eedc83a923d3bc711c
> (net: 3com: slight optimization of addr compare)
> cause a warning: "passing argument 1 of 'ether_addr_equal'
> from incompatible pointer type", so fix it.
>
> I think julia will convert ether_addr_equal to ether_addr_equal_64bits later.
>
> Cc: "David S. Miller" <davem@davemloft.net>
> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-14 7:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-11 8:23 [PATCH net-next 2/2] net: 3com: fix warning for incorrect type in argument Ding Tianhong
2014-01-14 7:31 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).