* [PATCH net-next] ipv4: remove the useless argument from ip_tunnel_hash()
@ 2014-01-12 10:04 Duan Jiong
2014-01-13 13:55 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: Duan Jiong @ 2014-01-12 10:04 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Since commit c544193214 introduced function ip_tunnel_hash(), the argument
itn is no longer in use, so remove it.
Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
---
net/ipv4/ip_tunnel.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c
index d3929a6..6f5a347 100644
--- a/net/ipv4/ip_tunnel.c
+++ b/net/ipv4/ip_tunnel.c
@@ -61,8 +61,7 @@
#include <net/ip6_route.h>
#endif
-static unsigned int ip_tunnel_hash(struct ip_tunnel_net *itn,
- __be32 key, __be32 remote)
+static unsigned int ip_tunnel_hash(__be32 key, __be32 remote)
{
return hash_32((__force u32)key ^ (__force u32)remote,
IP_TNL_HASH_BITS);
@@ -204,7 +203,7 @@ struct ip_tunnel *ip_tunnel_lookup(struct ip_tunnel_net *itn,
struct ip_tunnel *t, *cand = NULL;
struct hlist_head *head;
- hash = ip_tunnel_hash(itn, key, remote);
+ hash = ip_tunnel_hash(key, remote);
head = &itn->tunnels[hash];
hlist_for_each_entry_rcu(t, head, hash_node) {
@@ -236,7 +235,7 @@ struct ip_tunnel *ip_tunnel_lookup(struct ip_tunnel_net *itn,
cand = t;
}
- hash = ip_tunnel_hash(itn, key, 0);
+ hash = ip_tunnel_hash(key, 0);
head = &itn->tunnels[hash];
hlist_for_each_entry_rcu(t, head, hash_node) {
@@ -292,7 +291,7 @@ static struct hlist_head *ip_bucket(struct ip_tunnel_net *itn,
else
remote = 0;
- h = ip_tunnel_hash(itn, parms->i_key, remote);
+ h = ip_tunnel_hash(parms->i_key, remote);
return &itn->tunnels[h];
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] ipv4: remove the useless argument from ip_tunnel_hash()
2014-01-12 10:04 [PATCH net-next] ipv4: remove the useless argument from ip_tunnel_hash() Duan Jiong
@ 2014-01-13 13:55 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2014-01-13 13:55 UTC (permalink / raw)
To: Duan Jiong, David Miller; +Cc: netdev
Hello.
On 12-01-2014 14:04, Duan Jiong wrote:
> Since commit c544193214 introduced function ip_tunnel_hash(), the argument
Please also specify that commit's summary line in parens.
> itn is no longer in use, so remove it.
> Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-13 13:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-12 10:04 [PATCH net-next] ipv4: remove the useless argument from ip_tunnel_hash() Duan Jiong
2014-01-13 13:55 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).