Re: [PATCHv2 net-next 1/5] {IPv4,xfrm} Add ESN support for AH egress part

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 13-01-2014 11:48, Fan Du wrote:

> This patch add esn support for AH output stage by attaching upper 32bits
> sequence number right after packet payload as specified by RFC 4302.

> Then the ICV value will guard upper 32bits sequence number as well when
> packet going out.

> Signed-off-by: Fan Du <fan.du@windriver.com>
> ---
>   net/ipv4/ah4.c |   25 +++++++++++++++++++++----
>   1 file changed, 21 insertions(+), 4 deletions(-)

> diff --git a/net/ipv4/ah4.c b/net/ipv4/ah4.c
> index 7179026..a7fac03 100644
> --- a/net/ipv4/ah4.c
> +++ b/net/ipv4/ah4.c
[...]
> @@ -213,7 +223,14 @@ static int ah_output(struct xfrm_state *x, struct sk_buff *skb)
>   	sg_init_table(sg, nfrags);
>   	skb_to_sgvec(skb, sg, 0, skb->len);
>
> -	ahash_request_set_crypt(req, sg, icv, skb->len);
> +	if ((x->props.flags & XFRM_STATE_ESN)) {

    What's the point in double parens here? The same question about the other 
patches....

WBR, Sergei