From: Ding Tianhong <dingtianhong@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <fubar@us.ibm.com>, <vfalico@redhat.com>, <edumazet@google.com>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH net 0/2] bonding: ensure that the TSO being set on bond master
Date: Tue, 14 Jan 2014 10:06:28 +0800 [thread overview]
Message-ID: <52D49BA4.7040706@huawei.com> (raw)
In-Reply-To: <20140113.111511.1204304092822372663.davem@davemloft.net>
On 2014/1/14 3:15, David Miller wrote:
> From: Ding Tianhong <dingtianhong@huawei.com>
> Date: Wed, 8 Jan 2014 15:28:21 +0800
>
>> The commit b0ce3508(bonding: allow TSO being set on bonding master)
>> has make the TSO being set for bond dev, but in some situation, if
>> the slave did not have the NETIF_F_SG features, the bond master will
>> miss the TSO features in netdev_fix_features because the TSO is
>> depended on SG. So I have to add SG and TSO features on bond master
>> together.
>>
>> The function netdev_add_tso_features() was only be used for bonding,
>> so no need to export it in netdevice.h, remove it and add it to bonding.
>
> As far as I can tell from the discussion, there is some issue wrt. TSO
> about what happens if SG is not supported by some of the slaves.
>
>>From my perspective it appears that some changes to these patches are
> necessary to handle that correctly.
>
> So I am going to mark them as "Changes Requested" in patchwork.
>
> If this is not the case, please resubmit these changes with appropriate
> explanations added to the commit message(s).
>
> Thanks.
>
>
Ok, thanks.
Regards
Ding
prev parent reply other threads:[~2014-01-14 2:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 7:28 [PATCH net 0/2] bonding: ensure that the TSO being set on bond master Ding Tianhong
2014-01-13 19:15 ` David Miller
2014-01-14 2:06 ` Ding Tianhong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D49BA4.7040706@huawei.com \
--to=dingtianhong@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).