From: Ding Tianhong <dingtianhong@huawei.com>
To: Jay Vosburgh <fubar@us.ibm.com>,
Veaceslav Falico <vfalico@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>
Subject: [PATCH net-next v2 0/2] bonding: ensure that the TSO being set on bond master
Date: Tue, 14 Jan 2014 17:00:07 +0800 [thread overview]
Message-ID: <52D4FC97.8020301@huawei.com> (raw)
The commit b0ce3508(bonding: allow TSO being set on bonding master)
has make the TSO being set for bond dev, but in some situation, if
the slave did not have the NETIF_F_SG features, the bond master will
miss the TSO features in netdev_fix_features because the TSO is
depended on SG. So I have to add SG and TSO features on bond master
together.
The function netdev_add_tso_features() was only be used for bonding,
so no need to export it in netdevice.h, remove it and add it to bonding.
v2: If the slave hw did not support SG features, the SG should not
be forced open on master, otherwise error will occur, so modify it.
Some slave may support SG but not open it yet, so the bond master
could try to open it when adding the salve and make sure the TSO
could be open on master.
Ding Tianhong (2):
bonding: move the netdev_add_tso_features() to bonding
bonding: try to enable SG features when adding a new slave
drivers/net/bonding/bond_main.c | 27 ++++++++++++++++++++++++++-
include/linux/netdevice.h | 10 ----------
2 files changed, 26 insertions(+), 11 deletions(-)
--
1.8.0
next reply other threads:[~2014-01-14 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 9:00 Ding Tianhong [this message]
2014-01-14 9:47 ` [PATCH net-next v2 0/2] bonding: ensure that the TSO being set on bond master Veaceslav Falico
2014-01-14 10:38 ` Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D4FC97.8020301@huawei.com \
--to=dingtianhong@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).