From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fan Du Subject: Re: [PATCHv3 net-next 2/5] {IPv4,xfrm} Add ESN support for AH ingress part Date: Tue, 14 Jan 2014 18:01:32 +0800 Message-ID: <52D50AFC.6030302@windriver.com> References: <1389663552-29638-1-git-send-email-fan.du@windriver.com> <1389663552-29638-3-git-send-email-fan.du@windriver.com> <20140114095425.GH31491@secunet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: , To: Steffen Klassert Return-path: Received: from mail.windriver.com ([147.11.1.11]:36097 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbaANKCZ (ORCPT ); Tue, 14 Jan 2014 05:02:25 -0500 In-Reply-To: <20140114095425.GH31491@secunet.com> Sender: netdev-owner@vger.kernel.org List-ID: On 2014=E5=B9=B401=E6=9C=8814=E6=97=A5 17:54, Steffen Klassert wrote: > On Tue, Jan 14, 2014 at 09:39:09AM +0800, Fan Du wrote: >> @@ -381,7 +393,14 @@ static int ah_input(struct xfrm_state *x, struc= t sk_buff *skb) >> sg_init_table(sg, nfrags); >> skb_to_sgvec(skb, sg, 0, skb->len); >> >> - ahash_request_set_crypt(req, sg, icv, skb->len); >> + if (x->props.flags& XFRM_STATE_ESN) { >> + sg_unmark_end(&sg[nfrags - 1]); >> + /* Attach seqhi sg right after packet payload */ >> + *seqhi =3D htonl(XFRM_SKB_CB(skb)->seq.output.hi); > > This is ah_input(), so you should use the high bits of the input > sequence number here. The ipv6 patch has the same problem. ok, I will fix this. > >> + sg_init_table(seqhisg, sglists); > > Why do you add a separate SG table for this? It just initialize a single seqhisg, which is actually followed behind = packet payload sg table. initialized seqhisg actually mark itself as the end of sg list. --=20 =E6=B5=AE=E6=B2=89=E9=9A=8F=E6=B5=AA=E5=8F=AA=E8=AE=B0=E4=BB=8A=E6=9C=9D= =E7=AC=91 --fan