From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ding Tianhong Subject: Re: [PATCH net-next v2 0/2] bonding: ensure that the TSO being set on bond master Date: Tue, 14 Jan 2014 18:38:42 +0800 Message-ID: <52D513B2.9060203@huawei.com> References: <52D4FC97.8020301@huawei.com> <20140114094741.GB20066@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Jay Vosburgh , Eric Dumazet , "David S. Miller" , Netdev To: Veaceslav Falico Return-path: Received: from szxga01-in.huawei.com ([119.145.14.64]:31289 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751299AbaANKjd (ORCPT ); Tue, 14 Jan 2014 05:39:33 -0500 In-Reply-To: <20140114094741.GB20066@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On 2014/1/14 17:47, Veaceslav Falico wrote: > On Tue, Jan 14, 2014 at 05:00:07PM +0800, Ding Tianhong wrote: >> The commit b0ce3508(bonding: allow TSO being set on bonding master) >> has make the TSO being set for bond dev, but in some situation, if >> the slave did not have the NETIF_F_SG features, the bond master will >> miss the TSO features in netdev_fix_features because the TSO is >> depended on SG. So I have to add SG and TSO features on bond master >> together. >> >> The function netdev_add_tso_features() was only be used for bonding, >> so no need to export it in netdevice.h, remove it and add it to bonding. >> >> v2: If the slave hw did not support SG features, the SG should not >> be forced open on master, otherwise error will occur, so modify it. >> Some slave may support SG but not open it yet, so the bond master >> could try to open it when adding the salve and make sure the TSO >> could be open on master. > > So you're forcibly enabling SG on a slave? Usually SG is always enabled, > unless there's a very specific reason for that - like a bug in hw/sw/fw, > like performance improvement on specific use-cases etc. etc. > > So that's a wrong thing to do - to try to enable it, if it was disabled. > I don't think it is a wrong thing, just a slight changes of use, but your word is reasonable, I will miss it. > Nacked-by: Veaceslav Falico > >> >> Ding Tianhong (2): >> bonding: move the netdev_add_tso_features() to bonding >> bonding: try to enable SG features when adding a new slave >> >> drivers/net/bonding/bond_main.c | 27 ++++++++++++++++++++++++++- >> include/linux/netdevice.h | 10 ---------- >> 2 files changed, 26 insertions(+), 11 deletions(-) >> >> -- >> 1.8.0 >> >> > >