From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh_eth: fix garbled TX error message
Date: Tue, 14 Jan 2014 15:49:32 +0400 [thread overview]
Message-ID: <52D5244C.6070603@cogentembedded.com> (raw)
In-Reply-To: <20140113.232935.776174177146650322.davem@davemloft.net>
Hello.
On 14-01-2014 11:29, David Miller wrote:
>> sh_eth_error() in case of a TX error tries to print a message using 2 dev_err()
>> calls with the first string not finished by '\n', so that the resulting message
>> would inevitably come out garbled, with something like "3net eth0: " inserted
>> in the middle. Avoid that by merging 2 calls into one.
>> While at it, insert an empty line after the nearby declaration.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Applied, thanks.
> I don't think this is really -stable material, sorry.
Right, this is not even a fix anymore, at least not from 2.6.31 times (if
Joe's estimate was correct), and I was going to resubmit it as a cleanup.
Should have warned you not to apply yet but didn't, sorry.
WBR, Sergei
prev parent reply other threads:[~2014-01-14 11:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 23:41 [PATCH] sh_eth: fix garbled TX error message Sergei Shtylyov
2014-01-13 0:45 ` Simon Horman
2014-01-13 1:24 ` Joe Perches
2014-01-13 16:15 ` Sergei Shtylyov
2014-01-13 16:51 ` Joe Perches
2014-01-14 7:29 ` David Miller
2014-01-14 11:49 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D5244C.6070603@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).