From: Florent Fourcot <florent.fourcot@enst-bretagne.fr>
To: netdev@vger.kernel.org,
Hannes Frederic Sowa <hannes@stressinduktion.org>
Subject: Re: [PATCH V2 net-next 1/3] ipv6: add the IPV6_FL_F_REFLECT flag to IPV6_FL_A_GET
Date: Thu, 16 Jan 2014 13:45:18 +0100 [thread overview]
Message-ID: <52D7D45E.6000908@enst-bretagne.fr> (raw)
In-Reply-To: <20140116123515.GD7436@order.stressinduktion.org>
>> Was there a specific reason you did not use np->flow_label here and just
>> mirroring the flowlabel from the first packet of the connection for the
>> whole connection?
>>
>> I don't know if it makes a difference, but maybe it was done on purpose?
>
> I thought about it and am actually in favor of reusing the flowid from the syn
> packet so userspace does report correct outgoing flowlabel even in case of
> strange tcp peer changing it mid-stream.
>
Actually, the idea was that the remote could changed the flow label
during the lifetime of a connection.
I do not have a strong opinion on that, but in a "reflect" mode, I
except that the last received value will be in used.
Second, in case of SYN cookie, is the SYN flow label stored somewhere?
Thanks,
Florent.
next prev parent reply other threads:[~2014-01-16 12:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 11:30 [PATCH V2 net-next 1/3] ipv6: add the IPV6_FL_F_REFLECT flag to IPV6_FL_A_GET Florent Fourcot
2014-01-15 11:30 ` [PATCH V2 net-next 2/3] ipv6: add a flag to get the flow label used remotly Florent Fourcot
2014-01-15 11:30 ` [PATCH V2 net-next 3/3] ipv6: add ip6_flowlabel_consistency sysctl Florent Fourcot
2014-01-15 22:49 ` Hannes Frederic Sowa
2014-01-16 0:52 ` David Miller
2014-01-15 22:47 ` [PATCH V2 net-next 1/3] ipv6: add the IPV6_FL_F_REFLECT flag to IPV6_FL_A_GET Hannes Frederic Sowa
2014-01-16 12:35 ` Hannes Frederic Sowa
2014-01-16 12:45 ` Florent Fourcot [this message]
2014-01-16 13:07 ` Hannes Frederic Sowa
2014-01-16 14:34 ` Florent Fourcot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D7D45E.6000908@enst-bretagne.fr \
--to=florent.fourcot@enst-bretagne.fr \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).