Re: [PATCH net-next v2 0/2] bonding: add slave netlink and sysfs support

[Ding Tianhong <dingtianhong@huawei.com>]

On 2014/1/17 14:57, Scott Feldman wrote:
> v2:
> 
>   - Address review comment from Ding (and Veacesiav): handle kobj cleanup
>     if sysfs_create_file() fails when adding slave attribute nodes.
> 
> v1:
> 
>   The following series adds bonding slave netlink and sysfs interfaces.
>   Slave interfaces get a new IFLA_SLAVE set of netlink attributes, along
>   with RTM_NEWLINK notification when slave's active status changes.  The
>   sysfs interface adds read-only nodes for slave attributes under a /slave
>   dir, simliar to how bond interfaces get a /bonding dir for bonding
>   attributes.
> 
> ---
> 
> Scott Feldman (2):
>       bonding: add sysfs /slave dir for bond slave devices.
>       bonding: add netlink attributes to slave link dev
> 
> 
>  drivers/net/bonding/Makefile           |    2 
>  drivers/net/bonding/bond_main.c        |   28 ++++++
>  drivers/net/bonding/bond_netlink.c     |   36 ++++++++
>  drivers/net/bonding/bond_procfs.c      |   12 ---
>  drivers/net/bonding/bond_sysfs_slave.c |  144 ++++++++++++++++++++++++++++++++
>  drivers/net/bonding/bonding.h          |   15 +++
>  include/linux/netdevice.h              |    5 +
>  include/uapi/linux/if_link.h           |   13 +++
>  net/core/rtnetlink.c                   |   54 ++++++++++++
>  9 files changed, 294 insertions(+), 15 deletions(-)
>  create mode 100644 drivers/net/bonding/bond_sysfs_slave.c
> 
Reviewed-by: Ding Tianhong <dingtianhong@huawei.com>