From: Daniel Borkmann <dborkman@redhat.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "'Hannes Frederic Sowa'" <hannes@stressinduktion.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jakub Zawadzki <darkjames-ws@darkjames.pl>,
Eric Dumazet <eric.dumazet@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2 2/3] net: add trim helper and convert users
Date: Fri, 17 Jan 2014 11:06:28 +0100 [thread overview]
Message-ID: <52D900A4.9020509@redhat.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D45EAC0@AcuExch.aculab.com>
On 01/17/2014 10:52 AM, David Laight wrote:
> From: Hannes Frederic Sowa
> ...
>> +/**
>> + * trim - perform a reciprocal multiplication in order to "clamp" a
>> + * value into range [0, ep_ro), where the upper interval
>> + * endpoint is right-open. This is useful, e.g. for accessing
>> + * a index of an array containing ep_ro elements, for example.
>> + * Think of it as sort of modulus, only that the result isn't
>> + * that of modulo. ;)
>> + * More: http://homepage.cs.uiowa.edu/~jones/bcd/divide.html
>
> It isn't appropriate to put urls into code comments (or commit messages).
> They are very likely to get out of date.
Then please grep the git log for some references/urls, you'll find plenty.
This link is just a pointer for people interested to read some more
background; there's no need to overly elaborate in the kernel doc right
here.
Thanks !
> David
>
>
>
next prev parent reply other threads:[~2014-01-17 10:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 0:28 [PATCH net-next v2 0/3] reciprocal_divide updates Hannes Frederic Sowa
2014-01-17 0:28 ` [PATCH net-next v2 1/3] random32: add prandom_u32_max and convert open coded users Hannes Frederic Sowa
2014-01-17 0:28 ` [PATCH net-next v2 2/3] net: add trim helper and convert users Hannes Frederic Sowa
2014-01-17 9:52 ` David Laight
2014-01-17 10:06 ` Daniel Borkmann [this message]
2014-01-17 18:15 ` Ben Hutchings
2014-01-17 19:08 ` Eric Dumazet
2014-01-17 0:28 ` [PATCH net-next v2 3/3] reciprocal_divide: correction/update of the algorithm Hannes Frederic Sowa
2014-01-17 2:33 ` Eric Dumazet
2014-01-17 4:29 ` Hannes Frederic Sowa
2014-01-17 5:42 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D900A4.9020509@redhat.com \
--to=dborkman@redhat.com \
--cc=David.Laight@ACULAB.COM \
--cc=darkjames-ws@darkjames.pl \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).