From: Florent Fourcot <florent.fourcot@enst-bretagne.fr>
To: netdev@vger.kernel.org,
Hannes Frederic Sowa <hannes@stressinduktion.org>
Subject: Re: [PATCH V3 net-next 1/3] ipv6: add the IPV6_FL_F_REFLECT flag to IPV6_FL_A_GET
Date: Fri, 17 Jan 2014 13:16:55 +0100 [thread overview]
Message-ID: <52D91F37.8060602@enst-bretagne.fr> (raw)
In-Reply-To: <20140117012722.GA24345@order.stressinduktion.org>
Le 17/01/2014 02:27, Hannes Frederic Sowa a écrit :
> On Thu, Jan 16, 2014 at 05:19:16PM +0100, Florent Fourcot wrote:
>> @@ -1000,6 +1002,8 @@ static int tcp_v6_conn_request(struct sock *sk, struct sk_buff *skb)
>> ireq = inet_rsk(req);
>> ireq->ir_v6_rmt_addr = ipv6_hdr(skb)->saddr;
>> ireq->ir_v6_loc_addr = ipv6_hdr(skb)->daddr;
>> + if (np->repflow)
>> + np->flow_label = ip6_flowlabel(ipv6_hdr(skb));
>> if (!want_cookie || tmp_opt.tstamp_ok)
>> TCP_ECN_create_request(req, skb, sock_net(sk));
>>
>
> I am not sure here, do you write the flow_label on the listening socket?
>
Hum, yes. You are right, this is bad.
One alternative is not so simple. Perhaps could we store the flowlabel
in inet_request_sock? It will be available in the tcp_v6_send_synack
function, even in case of retransmission.
next prev parent reply other threads:[~2014-01-17 12:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 16:19 [PATCH V3 net-next 1/3] ipv6: add the IPV6_FL_F_REFLECT flag to IPV6_FL_A_GET Florent Fourcot
2014-01-16 16:19 ` [PATCH V3 net-next 2/3] ipv6: add a flag to get the flow label used remotly Florent Fourcot
2014-01-16 16:19 ` [PATCH V3 net-next 3/3] ipv6: add flowlabel_consistency sysctl Florent Fourcot
2014-01-16 23:41 ` [PATCH V3 net-next 1/3] ipv6: add the IPV6_FL_F_REFLECT flag to IPV6_FL_A_GET Hannes Frederic Sowa
2014-01-16 23:53 ` Hannes Frederic Sowa
2014-01-17 1:27 ` Hannes Frederic Sowa
2014-01-17 12:16 ` Florent Fourcot [this message]
2014-01-17 15:18 ` Florent Fourcot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D91F37.8060602@enst-bretagne.fr \
--to=florent.fourcot@enst-bretagne.fr \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).