From: Daniel Borkmann <dborkman@redhat.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [PATCH net-next] net: vxlan: do not use vxlan_net before checking event type
Date: Fri, 17 Jan 2014 19:32:38 +0100 [thread overview]
Message-ID: <52D97746.1040408@redhat.com> (raw)
In-Reply-To: <CAM_iQpV4FGdbHo9UVFhN9yqhZuGEZdrynikvrTZ0YZJTPVCmLg@mail.gmail.com>
On 01/17/2014 06:30 PM, Cong Wang wrote:
> On Fri, Jan 17, 2014 at 3:55 AM, Daniel Borkmann <dborkman@redhat.com> wrote:
>> - if (event == NETDEV_UNREGISTER)
>> + if (event == NETDEV_UNREGISTER) {
>> + vn = net_generic(dev_net(dev), vxlan_net_id);
>> vxlan_handle_lowerdev_unregister(vn, dev);
>> + }
>
> There is no need to keep vxlan_handle_lowerdev_unregister(),
> it is too short. So, just use my patch.
If you want to do cleanups, whatever, I really don't care.
You had your chance to complain about that when you reviewed
the initial version ... it has nothing to do with the fix.
next prev parent reply other threads:[~2014-01-17 18:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 11:55 [PATCH net-next] net: vxlan: do not use vxlan_net before checking event type Daniel Borkmann
2014-01-17 17:30 ` Cong Wang
2014-01-17 18:32 ` Daniel Borkmann [this message]
2014-01-18 3:50 ` Cong Wang
2014-01-18 17:18 ` Eric Dumazet
2014-01-18 17:57 ` Cong Wang
2014-01-18 19:47 ` Daniel Borkmann
2014-01-18 23:32 ` Cong Wang
2014-01-18 23:48 ` Cong Wang
2014-01-19 0:36 ` Daniel Borkmann
2014-01-19 0:50 ` Cong Wang
[not found] ` <1390072047.31367.543.camel@edumazet-glaptop2.roam.corp.google.com>
2014-01-18 23:38 ` Cong Wang
2014-01-19 2:01 ` Eric Dumazet
2014-01-17 18:20 ` Jesse Brandeburg
2014-01-18 2:50 ` David Miller
2014-01-20 21:51 ` Eric W. Biederman
2014-01-20 22:01 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D97746.1040408@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).