From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Yasevich Subject: Re: [PATCH net-next 0/7] sctp: remove some macro locking wrappers Date: Tue, 21 Jan 2014 10:16:09 -0500 Message-ID: <52DE8F39.30902@gmail.com> References: <1390290252-16080-1-git-send-email-wangweidong1@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: dborkman@redhat.com, netdev@vger.kernel.org, linux-sctp@vger.kernel.org To: Wang Weidong , nhorman@tuxdriver.com, davem@davemloft.net Return-path: Received: from mail-qa0-f46.google.com ([209.85.216.46]:53820 "EHLO mail-qa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754658AbaAUPQP (ORCPT ); Tue, 21 Jan 2014 10:16:15 -0500 In-Reply-To: <1390290252-16080-1-git-send-email-wangweidong1@huawei.com> Sender: netdev-owner@vger.kernel.org List-ID: On 01/21/2014 02:44 AM, Wang Weidong wrote: > In sctp.h we can find some macro locking wrappers. As Neil point out that: > > "Its because in the origional implementation of the sctp protocol, there was a > user space test harness which built the kernel module for userspace execution to > cary our some unit testing on the code. It did so by redefining some of those > locking macros to user space friendly code. IIRC we haven't use those unit > tests in years, and so should be removing them, not adding them to other > locations." > > So I remove them. > > Wang Weidong (7): > sctp: remove macro sctp_spin_[un]lock_irqrestore > sctp: remove macro sctp_local_bh_{disable|enable} > sctp: remove macro sctp_spin_[un]lock > sctp: remove macros sctp_write_[un]_lock > sctp: remove macros sctp_read_[un]lock > sctp: remove macros sctp_{lock|release}_sock > sctp: remove macros sctp_bh_[un]lock_sock > > include/net/sctp/sctp.h | 27 ++----------- > net/sctp/endpointola.c | 4 +- > net/sctp/input.c | 54 +++++++++++++------------- > net/sctp/proc.c | 12 +++--- > net/sctp/protocol.c | 4 +- > net/sctp/sm_sideeffect.c | 16 ++++---- > net/sctp/socket.c | 98 ++++++++++++++++++++++++------------------------ > 7 files changed, 98 insertions(+), 117 deletions(-) > I like this series just the way it is. Very simple to review. Series Acked-by: Vlad Yasevich Thanks -vlad