From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gao feng <gaofeng@cn.fujitsu.com>
Subject: Re: [PATCH] ipv6: reallocate addrconf router for ipv6 address when
 lo device up
Date: Fri, 24 Jan 2014 09:14:38 +0800
Message-ID: <52E1BE7E.1080009@cn.fujitsu.com>
References: <1390460277-23451-1-git-send-email-gaofeng@cn.fujitsu.com> <52E18614.6040104@cogentembedded.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: davem@davemloft.net, Sabrina Dubroca <sd@queasysnail.net>,
	Hannes Frederic Sowa <hannes@stressinduktion.org>,
	Weilong Chen <chenweilong@huawei.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from cn.fujitsu.com ([222.73.24.84]:19234 "EHLO song.cn.fujitsu.com"
	rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1751544AbaAXBNn (ORCPT <rfc822;netdev@vger.kernel.org>);
	Thu, 23 Jan 2014 20:13:43 -0500
In-Reply-To: <52E18614.6040104@cogentembedded.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 01/24/2014 05:13 AM, Sergei Shtylyov wrote:
> Hello.
> 
> On 23-01-2014 10:57, Gao feng wrote:
> 
>> commit 25fb6ca4ed9cad72f14f61629b68dc03c0d9713f
>> "net IPv6 : Fix broken IPv6 routing table after loopback down-up"
>> allocates addrconf router for ipv6 address when lo device up.
>> but commit a881ae1f625c599b460cc8f8a7fcb1c438f699ad
>> "ipv6:don't call addrconf_dst_alloc again when enable lo" breaks
>> this behavior.
> 
>> Since the addrconf router is moved to the garbage list when
>> lo device down, we should delete this router and rellocate
>> a new one for ipv6 address when lo device up.
> 
>> This patch solves bug 67951 on bugzilla
>> https://bugzilla.kernel.org/show_bug.cgi?id=67951
> 
>> CC: Sabrina Dubroca <sd@queasysnail.net>
>> CC: Hannes Frederic Sowa <hannes@stressinduktion.org>
>> Reported-by: Weilong Chen <chenweilong@huawei.com>
>> Signed-off-by: Weilong Chen <chenweilong@huawei.com>
>> Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
>> ---
>>   net/ipv6/addrconf.c | 13 +++++++++++--
>>   1 file changed, 11 insertions(+), 2 deletions(-)
> 
>> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
>> index 4b6b720..6eecd9d 100644
>> --- a/net/ipv6/addrconf.c
>> +++ b/net/ipv6/addrconf.c
>> @@ -2611,8 +2611,17 @@ static void init_loopback(struct net_device *dev)
>>               if (sp_ifa->flags & (IFA_F_DADFAILED | IFA_F_TENTATIVE))
>>                   continue;
>>
>> -            if (sp_ifa->rt)
>> -                continue;
>> +            if (sp_ifa->rt) {
>> +                /* This dst has been added to garbage list when
>> +                 * lo device down, delete this obsolete dst and
>> +                 * reallocate a new router for ifa.
>> +                 */
>> +                if (sp_ifa->rt->dst.obsolete > 0) {
>> +                    ip6_del_rt(sp_ifa->rt);
>> +                    sp_ifa->rt = NULL;
>> +                } else
>> +                    continue;
> 
>    *else* arm should have {} when the other arm of *if* statement has it -- see Documentation/CodingStyle.
> 

Thanks!

will add in v2.