* [PATCH net-next v3 0/2] bonding: Fix some issues for fail_over_mac
@ 2014-01-24 4:27 Ding Tianhong
2014-01-25 2:04 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Ding Tianhong @ 2014-01-24 4:27 UTC (permalink / raw)
To: Jay Vosburgh, Veaceslav Falico, David S. Miller, Netdev,
Andy Gospodarek
The parameter fail_over_mac only affect active-backup mode, if it was
set to active or follow and works with other modes, just like RR or XOR
mode, the bonding could not set all slaves to the master's address, it
will cause the slave could not work well with master.
So set the fail_over_mac to none if the mode is not active-backup and
slight optimization for bond_set_mac_address().
v1->v2: According Jay's suggestion, that we should permit setting an option
at any time, but only have it take effect in active-backup mode, so
I add mode checking together with fail_over_mac during enslavement and
rebuild the patches.
v2->v3: The correct way to fix the problem is that we should not add restrictions when
setting options, just need to modify the bond enslave and removal processing
to check the mode in addition to fail_over_mac when setting a slave's MAC during
enslavement. The change active slave processing already only calls the fail_over_mac
function when in active-backup mode.
Remove the cleanup patch because the net-next is frozen now.
Regards
Ding
Ding Tianhong (2):
bonding: bonding: fail_over_mac should only affect AB mode at
enslave and removal processing
bonding: fail_over_mac should only affect AB mode in
bond_set_mac_address()
drivers/net/bonding/bond_main.c | 25 +++++++++++++++++--------
1 file changed, 17 insertions(+), 8 deletions(-)
--
1.8.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next v3 0/2] bonding: Fix some issues for fail_over_mac
2014-01-24 4:27 [PATCH net-next v3 0/2] bonding: Fix some issues for fail_over_mac Ding Tianhong
@ 2014-01-25 2:04 ` David Miller
2014-01-25 4:56 ` Ding Tianhong
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2014-01-25 2:04 UTC (permalink / raw)
To: dingtianhong; +Cc: fubar, vfalico, netdev, andy
From: Ding Tianhong <dingtianhong@huawei.com>
Date: Fri, 24 Jan 2014 12:27:28 +0800
> So set the fail_over_mac to none if the mode is not active-backup and
> slight optimization for bond_set_mac_address().
This is no longer how your series fixes the problem, please fix this
text and resubmit.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v3 0/2] bonding: Fix some issues for fail_over_mac
2014-01-25 2:04 ` David Miller
@ 2014-01-25 4:56 ` Ding Tianhong
0 siblings, 0 replies; 3+ messages in thread
From: Ding Tianhong @ 2014-01-25 4:56 UTC (permalink / raw)
To: David Miller; +Cc: fubar, vfalico, netdev, andy
On 2014/1/25 10:04, David Miller wrote:
> From: Ding Tianhong <dingtianhong@huawei.com>
> Date: Fri, 24 Jan 2014 12:27:28 +0800
>
>> So set the fail_over_mac to none if the mode is not active-backup and
>> slight optimization for bond_set_mac_address().
>
> This is no longer how your series fixes the problem, please fix this
> text and resubmit.
>
>
OK, sorry for that.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-25 4:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-24 4:27 [PATCH net-next v3 0/2] bonding: Fix some issues for fail_over_mac Ding Tianhong
2014-01-25 2:04 ` David Miller
2014-01-25 4:56 ` Ding Tianhong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).