From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next v2 1/5] net_sched: act: hide struct tcf_common from API
Date: Mon, 27 Jan 2014 07:11:47 -0500 [thread overview]
Message-ID: <52E64D03.7000506@mojatatu.com> (raw)
In-Reply-To: <1390516525-8556-2-git-send-email-xiyou.wangcong@gmail.com>
On 01/23/14 17:35, Cong Wang wrote:
> Now we can totally hide it from modules. tcf_hash_*() API's
> will operate on struct tc_action, modules don't need to care about
> the details.
>
> Cc: Jamal Hadi Salim <jhs@mojatatu.com>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> ---
Cong, this patch does not compile by itself. I did not try the rest.
For git bisect to work:
Every patch should be compilable standalone and all tests should
pass with every single patch (the later part is my view, the first
is common practise)
Since Dave already closed the door - no rush, when you get the
cycles please fix this up. I am hoping to do a quick test run
when you are done.
cheers,
jamal
next prev parent reply other threads:[~2014-01-27 12:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 22:35 [Patch net-next v2 0/5] net_sched: act: more cleanup and improvement Cong Wang
2014-01-23 22:35 ` [Patch net-next v2 1/5] net_sched: act: hide struct tcf_common from API Cong Wang
2014-01-24 0:02 ` Stephen Hemminger
2014-01-24 0:04 ` Stephen Hemminger
2014-01-24 0:45 ` Cong Wang
2014-01-27 12:11 ` Jamal Hadi Salim [this message]
2014-01-28 5:17 ` Cong Wang
2014-01-23 22:35 ` [Patch net-next v2 2/5] net_sched: act: refactor cleanup ops Cong Wang
2014-01-23 22:35 ` [Patch net-next v2 3/5] net_sched: act: move tcf_hashinfo_init() into tcf_register_action() Cong Wang
2014-01-24 0:08 ` Stephen Hemminger
2014-01-24 0:52 ` Cong Wang
2014-01-23 22:35 ` [Patch net-next v2 4/5] net_sched: act: refuse to remove bound action outside Cong Wang
2014-01-23 22:35 ` [Patch net-next v2 5/5] net_sched: act: clean up tca_action_flush() Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E64D03.7000506@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).