From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Florian Vaussard <florian.vaussard@epfl.ch>,
Wolfgang Grandegger <wg@grandegger.com>
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] can: sja1000: cleanups and new OF property
Date: Thu, 30 Jan 2014 16:22:25 +0100 [thread overview]
Message-ID: <52EA6E31.2030604@pengutronix.de> (raw)
In-Reply-To: <1391092168-21246-1-git-send-email-florian.vaussard@epfl.ch>
[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]
Hello Florian,
On 01/30/2014 03:29 PM, Florian Vaussard wrote:
> The first part of this series performs serveral small cleanups
> (patches 1 to 3).
Thanks for your contribution. I like patches 1 and 2.
> The second part introduces the 'reg-io-width' binding (already used
> by some other drivers) to perform a similar job as what was done
> with IORESOURCE_MEM_XXBIT on the sja1000_platform. This is needed
> on my system to correctly take into account the aliasing of the
> address bus.
And I appreciate the improvements for the of_platform driver. However
that driver was written back when it was not possible to have platform
and of bindings in the same driver. So I'd like to see that the
of_platform driver gets merged into the platform driver.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
next prev parent reply other threads:[~2014-01-30 15:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 14:29 [PATCH 0/5] can: sja1000: cleanups and new OF property Florian Vaussard
2014-01-30 14:29 ` [PATCH 1/5] can: sja1000: remove unused defines Florian Vaussard
2014-01-30 14:29 ` [PATCH 2/5] can: sja1000: convert printk to use netdev API Florian Vaussard
2014-01-30 14:29 ` [PATCH 3/5] can: sja1000: of: use devm_* APIs Florian Vaussard
2014-01-30 14:29 ` [PATCH 4/5] Documentation: devicetree: sja1000: add reg-io-width binding Florian Vaussard
[not found] ` <1391092168-21246-5-git-send-email-florian.vaussard-p8DiymsW2f8@public.gmane.org>
2014-01-30 14:45 ` Rob Herring
2014-01-30 14:29 ` [PATCH 5/5] can: sja1000: of: add read/write routines for 8, 16 and 32-bit register access Florian Vaussard
2014-01-30 15:22 ` Marc Kleine-Budde [this message]
2014-01-30 15:27 ` [PATCH 0/5] can: sja1000: cleanups and new OF property Florian Vaussard
2014-01-30 15:36 ` Marc Kleine-Budde
2014-01-30 16:51 ` Florian Vaussard
2014-01-30 16:52 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EA6E31.2030604@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=florian.vaussard@epfl.ch \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).