From: Florian Vaussard <florian.vaussard@epfl.ch>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
Wolfgang Grandegger <wg@grandegger.com>
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/6] can: sja1000: cleanups and new OF property
Date: Fri, 31 Jan 2014 13:41:36 +0100 [thread overview]
Message-ID: <52EB9A00.9050102@epfl.ch> (raw)
In-Reply-To: <52EB9908.2090903@pengutronix.de>
Hello Marc,
On 01/31/2014 01:37 PM, Marc Kleine-Budde wrote:
> On 01/31/2014 11:35 AM, Florian Vaussard wrote:
>> Hello,
>>
>> Changes sinces v1:
>> - Merge sja1000_of_platform.c into sja1000_platform.c (patch 4)
>>
>> The first part of this series performs serveral small cleanups
>> (patches 1 to 3).
>>
>> Patch 4 merges sja1000_of_platform.c into sja1000_platform.c.
>> Changes are pretty conservatives (mostly copy/paste/move). IRQ
>> is treated differently in the OF and non-OF versions, thus this
>> is where the fused version differs the most.
>>
>> The final part introduces the 'reg-io-width' binding (already used
>> by some other drivers) to perform a similar job as what was done
>> with IORESOURCE_MEM_XXBIT. This is needed on my system to correctly
>> take into account the aliasing of the address bus.
>
> Good work, please keep compatibility for DTs without the 'reg-io-width'
> binding. The rest of my comments are only nitpicks. :)
>
Good points. I will send a v3.
Regards,
Florian
prev parent reply other threads:[~2014-01-31 12:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 10:35 [PATCH v2 0/6] can: sja1000: cleanups and new OF property Florian Vaussard
2014-01-31 10:35 ` [PATCH v2 1/6] can: sja1000: remove unused defines Florian Vaussard
2014-01-31 12:35 ` Marc Kleine-Budde
2014-01-31 10:35 ` [PATCH v2 2/6] can: sja1000: convert printk to use netdev API Florian Vaussard
2014-01-31 12:34 ` Marc Kleine-Budde
2014-01-31 10:35 ` [PATCH v2 3/6] can: sja1000: platform: use devm_* APIs Florian Vaussard
2014-01-31 12:34 ` Marc Kleine-Budde
2014-01-31 10:35 ` [PATCH v2 4/6] can: sja1000: fuse of_platform into platform Florian Vaussard
2014-01-31 12:33 ` Marc Kleine-Budde
2014-01-31 12:45 ` Florian Vaussard
2014-01-31 12:49 ` Marc Kleine-Budde
2014-01-31 12:51 ` Marc Kleine-Budde
2014-01-31 13:00 ` Florian Vaussard
2014-01-31 13:14 ` Marc Kleine-Budde
2014-01-31 10:35 ` [PATCH v2 5/6] Documentation: devicetree: sja1000: add reg-io-width binding Florian Vaussard
2014-01-31 12:29 ` Marc Kleine-Budde
2014-02-03 8:11 ` Florian Vaussard
2014-01-31 10:35 ` [PATCH v2 6/6] can: sja1000: of: add reg-io-width property for 8, 16 and 32-bit register access Florian Vaussard
2014-01-31 12:28 ` Marc Kleine-Budde
2014-01-31 12:37 ` [PATCH v2 0/6] can: sja1000: cleanups and new OF property Marc Kleine-Budde
2014-01-31 12:41 ` Florian Vaussard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EB9A00.9050102@epfl.ch \
--to=florian.vaussard@epfl.ch \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).