From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Subject: Re: [PATCH v3 0/5] can: sja1000: cleanups and new OF property Date: Fri, 31 Jan 2014 14:51:19 +0100 Message-ID: <52EBAA57.1030006@pengutronix.de> References: <1391175277-19833-1-git-send-email-florian.vaussard@epfl.ch> <52EBA7E2.6090007@pengutronix.de> <52EBAA28.1070307@gaisler.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Q66oVvLNa2SSR9OQ93aLclqkqo1uSPIxk" Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org To: Andreas Larsson , Florian Vaussard , Wolfgang Grandegger Return-path: In-Reply-To: <52EBAA28.1070307@gaisler.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Q66oVvLNa2SSR9OQ93aLclqkqo1uSPIxk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/31/2014 02:50 PM, Andreas Larsson wrote: > On 2014-01-31 14:40, Marc Kleine-Budde wrote: >> On 01/31/2014 02:34 PM, Florian Vaussard wrote: >>> Hello, >>> >>> (could someone with a SJA1000 on SPARC perform a functional test >>> to see if interrupts are working? it would be great :-) >>> >>> Changes since v2: >>> - Dropped patch 1 "can: sja1000: remove unused defines" >>> - Addressed Marc's comments on patch 4 and 6 (now 3 and 5) >>> >>> Changes since v1: >>> - Merge sja1000_of_platform.c into sja1000_platform.c (patch 4) >>> >>> The first part of this series performs serveral small cleanups >>> (patches 1 and 2). >>> >>> Patch 3 merges sja1000_of_platform.c into sja1000_platform.c. >>> Changes are pretty conservatives (mostly copy/paste/move). IRQ >>> is treated differently in the OF and non-OF versions, thus this >>> is where the fused version differs the most. >>> >>> The final part introduces the 'reg-io-width' binding (already used >>> by some other drivers) to perform a similar job as what was done >>> with IORESOURCE_MEM_XXBIT. This is needed on my system to correctly >>> take into account the aliasing of the address bus. >>> >>> All patches were tested using OF boot on my OMAP3 system with a >>> memory-mapped SJA1000. Thus, the non-OF path is not tested, as >>> I do not have a platform data at hand. >> >> Nice, looks good now. I'll give Andreas some time to test on sparc and= >> then apply the patches. >=20 >=20 > I am on it. I will dig up some hardware for this on Monday to test it. \o/ --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --Q66oVvLNa2SSR9OQ93aLclqkqo1uSPIxk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iEYEARECAAYFAlLrqlcACgkQjTAFq1RaXHMLlwCggtdKRGfRQMoiORcWHmFgy7tp OJ0An3YK5gt+UVu+53rkdrFhYsoeUbDQ =eKLA -----END PGP SIGNATURE----- --Q66oVvLNa2SSR9OQ93aLclqkqo1uSPIxk--