From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: [PATCH RFC 1/1] usb: Tell xhci when usb data might be misaligned Date: Sat, 01 Feb 2014 08:30:29 -0500 Message-ID: <52ECF6F5.6060207@pobox.com> References: <20140130211816.GB3787@xanatos> <87iot1qgv6.fsf@nemi.mork.no> <20140130221511.GD14228@xanatos> <20140131190035.GB18262@xanatos> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: =?UTF-8?B?QmrDuHJuIE1vcms=?= , David Laight , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" , Greg Kroah-Hartman , David Miller , Dan Williams , "Nyman, Mathias" , Alan Stern , Freddy Xin To: Ming Lei , Sarah Sharp Return-path: Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:44690 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932830AbaBANah (ORCPT ); Sat, 1 Feb 2014 08:30:37 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 14-02-01 02:54 AM, Ming Lei wrote: .. > With SG enabled, for the iperf client test case, the average urb size > for transmission will be increased from ~1500 to ~20K bytes in my > test case: > > iperf -c $SRV -t 30 -P 4 -w 128K > > So I am wondering you guys do not care the improvement .. No, that's not it. Simply, the recent changes killed the driver for some users, something Linus calls a "regression", and does not permit. Far better to have it continue to work than not to work. The plan discussed earlier calls for reintroduction of SG here once the problems are solved outside of the main tree. -- Mark Lord Real-Time Remedies Inc. mlord@pobox.com