From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zoltan Kiss Subject: Re: [Xen-devel] [PATCH v6] xen/grant-table: Avoid m2p_override during mapping Date: Mon, 3 Feb 2014 14:27:25 +0100 Message-ID: <52EF993D.1000701@citrix.com> References: <1390512224-27296-1-git-send-email-zoltan.kiss@citrix.com> <52EE1E26.2040308@linaro.org> <52EE93F0.1020508@citrix.com> <52EF7618.7030402@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: Julien Grall , Stefano Stabellini , , , , , , To: David Vrabel Return-path: In-Reply-To: <52EF7618.7030402@citrix.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 03/02/14 11:57, David Vrabel wrote: >> >> Hi, >> >> That's bad indeed. I think the best solution is to put those parts >> behind an #ifdef x86. The ones moved from x86/p2m.c to grant-table.c. >> David, Stefano, what do you think? > I don't think we want (more) #ifdef CONFIG_X86 in grant-table.c and the > arch-specific bits will have to factored out into their own functions > with suitable stubs provided for ARM. > I've just sent in v7 with stubs, I guess that's something you suggested. Please review it, I'm especially curious about your thoughts regarding the new function name. Zoli