From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shradha Shah Subject: Re: [PATCH-net] drivers/net: fix build warning in ethernet/sfc/tx.c Date: Thu, 6 Feb 2014 16:59:59 +0000 Message-ID: <52F3BF8F.4080506@solarflare.com> References: <1391705112-27869-1-git-send-email-paul.gortmaker@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: , , Jon Cooper , Ben Hutchings To: Paul Gortmaker Return-path: Received: from webmail.solarflare.com ([12.187.104.25]:41610 "EHLO webmail.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751366AbaBFRAE (ORCPT ); Thu, 6 Feb 2014 12:00:04 -0500 In-Reply-To: <1391705112-27869-1-git-send-email-paul.gortmaker@windriver.com> Sender: netdev-owner@vger.kernel.org List-ID: On 02/06/2014 04:45 PM, Paul Gortmaker wrote: > Commit ee45fd92c739db5b7950163d91dfe5f016af6d24 ("sfc: Use TX PIO > for sufficiently small packets") introduced the following warning: > > drivers/net/ethernet/sfc/tx.c: In function 'efx_enqueue_skb': > drivers/net/ethernet/sfc/tx.c:432:1: warning: label 'finish_packet' defined but not used > > Stick the label inside the same #ifdef that the code which calls > it uses. Note that this is only seen for arch that do not set > ARCH_HAS_IOREMAP_WC, such as arm, mips, sparc, ..., as the others > enable the write combining code and hence use the label. > > Cc: Jon Cooper > Cc: Ben Hutchings > Signed-off-by: Paul Gortmaker Acked-by: Shradha Shah > --- > drivers/net/ethernet/sfc/tx.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c > index c49d1fb16965..75d11fa4eb0a 100644 > --- a/drivers/net/ethernet/sfc/tx.c > +++ b/drivers/net/ethernet/sfc/tx.c > @@ -429,7 +429,9 @@ netdev_tx_t efx_enqueue_skb(struct efx_tx_queue *tx_queue, struct sk_buff *skb) > } > > /* Transfer ownership of the skb to the final buffer */ > +#ifdef EFX_USE_PIO > finish_packet: > +#endif > buffer->skb = skb; > buffer->flags = EFX_TX_BUF_SKB | dma_flags; > >