* [PATCH net] bonding: remove unwanted bond lock for enslave processing
@ 2014-02-10 8:33 Ding Tianhong
2014-02-10 8:49 ` Veaceslav Falico
2014-02-11 0:55 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Ding Tianhong @ 2014-02-10 8:33 UTC (permalink / raw)
To: Jay Vosburgh, Veaceslav Falico, Andy Gospodarek, David S. Miller,
Netdev
The bond enslave processing don't hold bond->lock anymore,
so release an unlocked rw lock will cause warning message,
remove the unwanted read_unlock(&bond->lock).
Cc: Jay Vosburgh <fubar@us.ibm.com>
Cc: Veaceslav Falico <vfalico@redhat.com>
Cc: Andy Gospodarek <andy@greyhouse.net>
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
---
drivers/net/bonding/bond_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index a7db819..ccfb998 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1505,7 +1505,6 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
slave_dev->npinfo = bond->dev->npinfo;
if (slave_dev->npinfo) {
if (slave_enable_netpoll(new_slave)) {
- read_unlock(&bond->lock);
pr_info("Error, %s: master_dev is using netpoll, "
"but new slave device does not support netpoll.\n",
bond_dev->name);
--
1.8.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] bonding: remove unwanted bond lock for enslave processing
2014-02-10 8:33 [PATCH net] bonding: remove unwanted bond lock for enslave processing Ding Tianhong
@ 2014-02-10 8:49 ` Veaceslav Falico
2014-02-11 0:55 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Veaceslav Falico @ 2014-02-10 8:49 UTC (permalink / raw)
To: Ding Tianhong; +Cc: Jay Vosburgh, Andy Gospodarek, David S. Miller, Netdev
On Mon, Feb 10, 2014 at 04:33:59PM +0800, Ding Tianhong wrote:
>The bond enslave processing don't hold bond->lock anymore,
>so release an unlocked rw lock will cause warning message,
>remove the unwanted read_unlock(&bond->lock).
>
>Cc: Jay Vosburgh <fubar@us.ibm.com>
>Cc: Veaceslav Falico <vfalico@redhat.com>
>Cc: Andy Gospodarek <andy@greyhouse.net>
>Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Good catch.
Acked-by: Veaceslav Falico <vfalico@redhat.com>
>---
> drivers/net/bonding/bond_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index a7db819..ccfb998 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -1505,7 +1505,6 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
> slave_dev->npinfo = bond->dev->npinfo;
> if (slave_dev->npinfo) {
> if (slave_enable_netpoll(new_slave)) {
>- read_unlock(&bond->lock);
> pr_info("Error, %s: master_dev is using netpoll, "
> "but new slave device does not support netpoll.\n",
> bond_dev->name);
>--
>1.8.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] bonding: remove unwanted bond lock for enslave processing
2014-02-10 8:33 [PATCH net] bonding: remove unwanted bond lock for enslave processing Ding Tianhong
2014-02-10 8:49 ` Veaceslav Falico
@ 2014-02-11 0:55 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-02-11 0:55 UTC (permalink / raw)
To: dingtianhong; +Cc: fubar, vfalico, andy, netdev
From: Ding Tianhong <dingtianhong@huawei.com>
Date: Mon, 10 Feb 2014 16:33:59 +0800
> The bond enslave processing don't hold bond->lock anymore,
> so release an unlocked rw lock will cause warning message,
> remove the unwanted read_unlock(&bond->lock).
>
> Cc: Jay Vosburgh <fubar@us.ibm.com>
> Cc: Veaceslav Falico <vfalico@redhat.com>
> Cc: Andy Gospodarek <andy@greyhouse.net>
> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-11 0:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-10 8:33 [PATCH net] bonding: remove unwanted bond lock for enslave processing Ding Tianhong
2014-02-10 8:49 ` Veaceslav Falico
2014-02-11 0:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).