* [PATCH net-next] net: remove useless if check from register_netdevice()
@ 2014-02-12 7:45 Denis Kirjanov
2014-02-12 8:20 ` Ding Tianhong
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Denis Kirjanov @ 2014-02-12 7:45 UTC (permalink / raw)
To: davem, netdev; +Cc: Denis Kirjanov
remove useless if check from register_netdevice()
Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
---
net/core/dev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 4ad1b78..4be9a37 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -5876,8 +5876,7 @@ int register_netdevice(struct net_device *dev)
if (dev->netdev_ops->ndo_init) {
ret = dev->netdev_ops->ndo_init(dev);
if (ret) {
- if (ret > 0)
- ret = -EIO;
+ ret = -EIO;
goto out;
}
}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net: remove useless if check from register_netdevice()
2014-02-12 7:45 [PATCH net-next] net: remove useless if check from register_netdevice() Denis Kirjanov
@ 2014-02-12 8:20 ` Ding Tianhong
2014-02-12 8:24 ` Ding Tianhong
2014-02-12 14:46 ` David Miller
2 siblings, 0 replies; 6+ messages in thread
From: Ding Tianhong @ 2014-02-12 8:20 UTC (permalink / raw)
To: Denis Kirjanov, davem, netdev
On 2014/2/12 15:45, Denis Kirjanov wrote:
> remove useless if check from register_netdevice()
>
> Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
> ---
> net/core/dev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 4ad1b78..4be9a37 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -5876,8 +5876,7 @@ int register_netdevice(struct net_device *dev)
> if (dev->netdev_ops->ndo_init) {
> ret = dev->netdev_ops->ndo_init(dev);
> if (ret) {
> - if (ret > 0)
> - ret = -EIO;
> + ret = -EIO;
pls use checkpatch.pl to check the code.
Ding
> goto out;
> }
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net: remove useless if check from register_netdevice()
2014-02-12 7:45 [PATCH net-next] net: remove useless if check from register_netdevice() Denis Kirjanov
2014-02-12 8:20 ` Ding Tianhong
@ 2014-02-12 8:24 ` Ding Tianhong
2014-02-12 8:47 ` Denis Kirjanov
2014-02-12 14:46 ` David Miller
2 siblings, 1 reply; 6+ messages in thread
From: Ding Tianhong @ 2014-02-12 8:24 UTC (permalink / raw)
To: Denis Kirjanov, davem, netdev
On 2014/2/12 15:45, Denis Kirjanov wrote:
> remove useless if check from register_netdevice()
>
> Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
> ---
> net/core/dev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 4ad1b78..4be9a37 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -5876,8 +5876,7 @@ int register_netdevice(struct net_device *dev)
> if (dev->netdev_ops->ndo_init) {
> ret = dev->netdev_ops->ndo_init(dev);
> if (ret) {
> - if (ret > 0)
> - ret = -EIO;
> + ret = -EIO;
and:
some ndo_init() will return -ENOMEM, not only -EIO
> goto out;
> }
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net: remove useless if check from register_netdevice()
2014-02-12 8:24 ` Ding Tianhong
@ 2014-02-12 8:47 ` Denis Kirjanov
0 siblings, 0 replies; 6+ messages in thread
From: Denis Kirjanov @ 2014-02-12 8:47 UTC (permalink / raw)
To: Ding Tianhong; +Cc: davem, netdev
On 2/12/14, Ding Tianhong <dingtianhong@huawei.com> wrote:
> On 2014/2/12 15:45, Denis Kirjanov wrote:
>> remove useless if check from register_netdevice()
>>
>> Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
>> ---
>> net/core/dev.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/net/core/dev.c b/net/core/dev.c
>> index 4ad1b78..4be9a37 100644
>> --- a/net/core/dev.c
>> +++ b/net/core/dev.c
>> @@ -5876,8 +5876,7 @@ int register_netdevice(struct net_device *dev)
>> if (dev->netdev_ops->ndo_init) {
>> ret = dev->netdev_ops->ndo_init(dev);
>> if (ret) {
>> - if (ret > 0)
>> - ret = -EIO;
>> + ret = -EIO;
>
> and:
> some ndo_init() will return -ENOMEM, not only -EIO
>
>
>> goto out;
>> }
>> }
>>
Yes, I was thinking about that. The return code may contain everything.
Probably it's better to propagate return value back to
register_netdevice. On the other hand the return value -ENOTSUPP for
register_netdevice return value looks odd...
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: remove useless if check from register_netdevice()
2014-02-12 7:45 [PATCH net-next] net: remove useless if check from register_netdevice() Denis Kirjanov
2014-02-12 8:20 ` Ding Tianhong
2014-02-12 8:24 ` Ding Tianhong
@ 2014-02-12 14:46 ` David Miller
2014-02-12 14:51 ` Denis Kirjanov
2 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2014-02-12 14:46 UTC (permalink / raw)
To: kda; +Cc: netdev
From: Denis Kirjanov <kda@linux-powerpc.org>
Date: Wed, 12 Feb 2014 11:45:52 +0400
> @@ -5876,8 +5876,7 @@ int register_netdevice(struct net_device *dev)
> if (dev->netdev_ops->ndo_init) {
> ret = dev->netdev_ops->ndo_init(dev);
> if (ret) {
> - if (ret > 0)
> - ret = -EIO;
> + ret = -EIO;
> goto out;
> }
Like your other patch you are not formatting this code properly at all.
If you cannot insert the correct TAB and space characters necessary
to indent the code properly, have something help you do it, such as
emacs's C-mode in "linux" mode.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net: remove useless if check from register_netdevice()
2014-02-12 14:46 ` David Miller
@ 2014-02-12 14:51 ` Denis Kirjanov
0 siblings, 0 replies; 6+ messages in thread
From: Denis Kirjanov @ 2014-02-12 14:51 UTC (permalink / raw)
To: David Miller; +Cc: netdev
On 2/12/14, David Miller <davem@davemloft.net> wrote:
> From: Denis Kirjanov <kda@linux-powerpc.org>
> Date: Wed, 12 Feb 2014 11:45:52 +0400
>
>> @@ -5876,8 +5876,7 @@ int register_netdevice(struct net_device *dev)
>> if (dev->netdev_ops->ndo_init) {
>> ret = dev->netdev_ops->ndo_init(dev);
>> if (ret) {
>> - if (ret > 0)
>> - ret = -EIO;
>> + ret = -EIO;
>> goto out;
>> }
>
> Like your other patch you are not formatting this code properly at all.
>
I'll resubmit both. Thank you.
> If you cannot insert the correct TAB and space characters necessary
> to indent the code properly, have something help you do it, such as
> emacs's C-mode in "linux" mode.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-12 14:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-12 7:45 [PATCH net-next] net: remove useless if check from register_netdevice() Denis Kirjanov
2014-02-12 8:20 ` Ding Tianhong
2014-02-12 8:24 ` Ding Tianhong
2014-02-12 8:47 ` Denis Kirjanov
2014-02-12 14:46 ` David Miller
2014-02-12 14:51 ` Denis Kirjanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).