netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: NETIF_F_HIGHDMA?
Date: Thu, 13 Feb 2014 02:00:19 +0300	[thread overview]
Message-ID: <52FBFD03.6000703@cogentembedded.com> (raw)

Hello.

    I fail to understand why this flag is needed at all. netdev-features.txt says:

  * Transmit DMA from high memory

On platforms where this is relevant, NETIF_F_HIGHDMA signals that
ndo_start_xmit can handle skbs with frags in high memory.

    TTBOMK, highmem is an area of the kernel *virtual* memory that maps 
physical memory that can't be directly mapped unto the linear kernel space, 
i.e. in case when there's more memory in the system than the kernel memory can 
directly map. But what this has to do with DMA which deals with the physical 
memory? High memory doesn't have to be beyond 4 GiB limit -- it can exist even 
on 32-bit system (consider 4 GiB memory and 2/2 or 3/1 GiB user/kernel VM 
split), contrary to the belief of the many Ethernet PCI drivers which only set 
NETIF_F_HIGHDMA when the PCI dual address cycle is supported (i.e. the address 
on PCI can be 64-bit)...

    So, in my opinion, each and every driver should set this flag (except 
maybe those arch-specific drivers where CONFIG_HIGHMEM is not supported but 
even it this case the flag wouldn't hurt), and hence it's not needed at all. 
What am I missing in my picture?

WBR, Sergei

             reply	other threads:[~2014-02-12 22:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-12 23:00 Sergei Shtylyov [this message]
2014-02-12 22:51 ` NETIF_F_HIGHDMA? David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52FBFD03.6000703@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).