From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E9C9C43381 for ; Fri, 8 Mar 2019 22:37:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55CB820643 for ; Fri, 8 Mar 2019 22:37:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="ZIyhKfr2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726381AbfCHWhZ (ORCPT ); Fri, 8 Mar 2019 17:37:25 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:39310 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726324AbfCHWhY (ORCPT ); Fri, 8 Mar 2019 17:37:24 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x28MONJr041503; Fri, 8 Mar 2019 22:37:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=rpDv4SJuOPooPeXxhqeGdQE0ScX4QthqX7oMOXrpL/Y=; b=ZIyhKfr2RTkTdQaL+R9cqJKCrSN8mNYAgZtZcgtYZ+anYwLleEwmyEh66M5Xo6HNmJFk XGU2N2ojbKWn7AbzNawBKJIqRPg+nBz+1ERphLe7Jyf1mZKW2ac/xySR4G6kEz5BPDB3 sAJiZrHTpuwEFuArvbVdAw/+hG1dFCyI9ZCUKjuHAga1AXmYL4NZ8uAAQNSY2MKhQxYE rQg/1+6mHbIW3bIeHRSEWoRbYAkqYxGkyJRzP3ul9hS41slhwH1q5Su6iE6fqr5wFT8D louaI33XX+3L2nRtmvs0lfzsfZzeMljKp/kKIF5ApMyfyrEarGBEhCDCU24qE581DalW JQ== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2130.oracle.com with ESMTP id 2qyfbeu311-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 08 Mar 2019 22:37:20 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x28MbK6U006381 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Mar 2019 22:37:20 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x28MbJIO028781; Fri, 8 Mar 2019 22:37:19 GMT Received: from [10.211.54.20] (/10.211.54.20) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 08 Mar 2019 14:37:19 -0800 Subject: Re: [net-next PATCH] net/rds: Return proper "tos" value to user-space To: "santosh.shilimkar@oracle.com" , Yanjun Zhu , netdev@vger.kernel.org Cc: David Miller References: <1549325089-16572-4-git-send-email-santosh.shilimkar@oracle.com> <20190307220106.9099-1-gerd.rausch@oracle.com> From: Gerd Rausch Message-ID: <52a2653e-6ac6-bdc7-5e6e-a7763eef968d@oracle.com> Date: Fri, 8 Mar 2019 14:37:19 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9189 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903080155 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 07/03/2019 17.37, santosh.shilimkar@oracle.com wrote: >> --- a/net/rds/connection.c >> +++ b/net/rds/connection.c >> @@ -736,6 +736,7 @@ static int rds_conn_info_visitor(struct rds_conn_path *cp, void *buffer) >>       cinfo->next_rx_seq = cp->cp_next_rx_seq; >>       cinfo->laddr = conn->c_laddr.s6_addr32[3]; >>       cinfo->faddr = conn->c_faddr.s6_addr32[3]; >> +    cinfo->tos = conn->c_tos; >>       strncpy(cinfo->transport, conn->c_trans->t_name, >>           sizeof(cinfo->transport)); >>       cinfo->flags = 0; >> > Transport function populates it "iinfo->tos" so 'rds-info -I' > already should be showing the correct output but we should popullate > it here to for socket option so looks good > "rds-info -I" did show the correct output, but "rds-info -n" did not: % rds-info -n RDS Connections: LocalAddr RemoteAddr Tos NextTX NextRX Flgs 192.168.253.2 192.168.253.1 159 46940 46264 --C- > Acked-by: Santosh Shilimkar > Thanks, Gerd