From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB3AC341653 for ; Tue, 13 Jan 2026 10:42:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768300981; cv=none; b=eNduFYeceLXFN/6lxuelREYtsDzjnwO1eJxhFrHFuxI2zDVWKfaLVe5hsFLOOBbFqKUa9Dyk9wcU2gq3ATx1gO+VgiEfSG9NVMeULvAbrlHq+EqXoUvSvQzbVdTAkaSa4pXLYZDEyidSkFew+uFCiW9Y5is8242NDvc13FcbHAA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768300981; c=relaxed/simple; bh=h/iEAdqPaIY6WKNvkMpng0b6z40syJH+JgYaAQOu/Gk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sodAjAgcW/5jNbju9koZ5VMr5YALNIoklABMZxsqPxYd7gV0OFSieQ4zf2ncal5YbFPSLRgIXk1cM4nJuq3oJIAtNTq9CmSGf734W4FxIsA3Uv/BRC/pt2UpTSm8cfeR2S0R++vFMwtA4ryYGjXOMnnil7gunC7/GnxwaYfwFkg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dbGTUi6x; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dbGTUi6x" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-47d182a8c6cso43365435e9.1 for ; Tue, 13 Jan 2026 02:42:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768300978; x=1768905778; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LkhtI/R2xS3vmnHvCQqFwCBZTI8re8hBml5kcRz0zBY=; b=dbGTUi6xuFCFDtZvChjPqVXFIpJBzcboY/+8bIt8Mpg5BT5HXHdalGDlR1fHJCL1dF wdff2CYW56pIKesR4Csgy3hQtn99aNLr+w92OSyWKhyzmYCA7BTuo35KlGTKeAZgutZt qXtVmXGOSdZYbkZmC7HGOVJN8ovdNPpEdQPbLk8+OHZoXxWrq+rvgEn45clEh+thX3T8 s0YXJChrVfPpnJ0GzFEuNa8G3f4SgakkPrTrv+7FgKytR+l+zr5RdgSdBW/vFaDVtNBl bfm7UB5ubRZECmu/fSdk5EkGS/ALXQNiBioDJaRvVRIfFmJEIsvC1g8NICR2plnfbOYH nCbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768300978; x=1768905778; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LkhtI/R2xS3vmnHvCQqFwCBZTI8re8hBml5kcRz0zBY=; b=tcq4qX19g1A2I4cSi5Sc8aJVv+PWlKW+T5KhB6knSmd2ZqMl/DYx9d9h6DsKXNJmGW nawI10dKJaef9ALOfdYGPfcSSZKd8eGqL03GLaVvz+f98mJ0pUzHVUW7zSOUl4vH+uVl r5r0JluRdM274V6UOu1RwDbQs9bT+q51q7JmkOU+l3MpOtprg8Ji9FhoR6xkq+VVLoo5 esKyXxmbLCLS/xueiCooHUbw25nbctuB/wRnmEX3J0074tL8dwyUSXyhI/EbgmyDwK1h 8pf/Mb2sKqkH6reCeK7JVQiml9xHtirxcXe6B+jBA/ARg3cOvObAG1Rr/NTd3s54xKTD 7W8Q== X-Forwarded-Encrypted: i=1; AJvYcCVmJzR+aBedyowLKn/rhCVK4VNRcICpni2mS91qXHdLhlM/s/r/YzAmHf3ruSJ9fsG8lcAQbOg=@vger.kernel.org X-Gm-Message-State: AOJu0YxkK9lhsk3iDctcFgl1ByVuA6EzqWFe7zCs4APfpMHGXsvBlMvV 2W/LIvJ9aYBWUSHup8CtOJTIcjJ2B14Q8avGrHf4bKc1rQoOFMb2cKL9 X-Gm-Gg: AY/fxX7BZ1TkEoZnKCpcGjNDdVw1wwNTvleguhd5nnFjddC9JWSNLUDmv04nMaGnFZy dGudvSbEBZhqBGv60P+Qf+UXWkjkla1JKTgNj24W43gCyS9yvVtJfWMYFLwp0EAB+rWIy4zO0pI 8+XhwsJdRokocTE9Cw9zxK2qxbZk62/olEMpg/CqUG5qIAleci9lTrANhphK7tZgyMAWmnAp4js yiDNMODpUIi8vxDc1fiK0Bhr0fyktD/rh3GUuSOxIm11t/CpKt7Dxsvdbq1Xl7AcOcrQK9eVR+G IZfedIJdG4FHAt6ladYZ34znExD5f0J+pTO4kQrABN7i/bH97KbXhKhEW7F5FOaAxtsiW9ZeL7H OgaVSOGz/jyQEto/lg31i5rL5E234SXI7oUJAtZdZAp2cb4EakG+8eNLGke4GbIPnam1Sp1uZLX 8LRMsnHayDBknukSZJYfmpCjYfQEdKkp80gMh3kiU4d2xq3SsssxhWIseM2NnhxqksAy6ClMF3C s9lEVi9Urno+BNYmIeXvHZDfAHQSWyH9gO6AoEEoFFGsaz8ybPd0wl4M6Ze5SVPnnv2Z0hQ+Hvu X-Google-Smtp-Source: AGHT+IFkZdiJcndAA0MyUMm8x2SeND7c9WKpL4+wjJVZyc9wRUscpxmE8qJsJDcPKd4tkE4BoGQKUg== X-Received: by 2002:a05:600c:3555:b0:47b:e2a9:2bd7 with SMTP id 5b1f17b1804b1-47d84b3b5dfmr248265925e9.19.1768300977891; Tue, 13 Jan 2026 02:42:57 -0800 (PST) Received: from ?IPV6:2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c? ([2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47ed9ea45cesm13306085e9.1.2026.01.13.02.42.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 02:42:57 -0800 (PST) Message-ID: <52b4ac3d-7634-4545-af11-e25b589db700@gmail.com> Date: Tue, 13 Jan 2026 10:42:52 +0000 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v8 6/9] eth: bnxt: adjust the fill level of agg queues with larger buffers To: Paolo Abeni , netdev@vger.kernel.org Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Jonathan Corbet , Michael Chan , Pavan Chebbi , Andrew Lunn , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Joshua Washington , Harshitha Ramamurthy , Saeed Mahameed , Tariq Toukan , Mark Bloch , Leon Romanovsky , Alexander Duyck , Ilias Apalodimas , Shuah Khan , Willem de Bruijn , Ankit Garg , Tim Hostetler , Alok Tiwari , Ziwei Xiao , John Fraker , Praveen Kaligineedi , Mohsin Bashir , Joe Damato , Mina Almasry , Dimitri Daskalakis , Stanislav Fomichev , Kuniyuki Iwashima , Samiullah Khawaja , Ahmed Zaki , Alexander Lobakin , David Wei , Yue Haibing , Haiyue Wang , Jens Axboe , Simon Horman , Vishwanath Seshagiri , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kselftest@vger.kernel.org, dtatulea@nvidia.com, io-uring@vger.kernel.org References: <8b6486d8a498875c4157f28171b5b0d26593c3d8.1767819709.git.asml.silence@gmail.com> <4db44c27-4654-46f9-be41-93bcf06302b2@redhat.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <4db44c27-4654-46f9-be41-93bcf06302b2@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/13/26 10:27, Paolo Abeni wrote: > On 1/9/26 12:28 PM, Pavel Begunkov wrote: >> From: Jakub Kicinski >> >> The driver tries to provision more agg buffers than header buffers >> since multiple agg segments can reuse the same header. The calculation >> / heuristic tries to provide enough pages for 65k of data for each header >> (or 4 frags per header if the result is too big). This calculation is >> currently global to the adapter. If we increase the buffer sizes 8x >> we don't want 8x the amount of memory sitting on the rings. >> Luckily we don't have to fill the rings completely, adjust >> the fill level dynamically in case particular queue has buffers >> larger than the global size. >> >> Signed-off-by: Jakub Kicinski >> [pavel: rebase on top of agg_size_fac, assert agg_size_fac] >> Signed-off-by: Pavel Begunkov >> --- >> drivers/net/ethernet/broadcom/bnxt/bnxt.c | 28 +++++++++++++++++++---- >> 1 file changed, 24 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c >> index 8f42885a7c86..137e348d2b9c 100644 >> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c >> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c >> @@ -3816,16 +3816,34 @@ static void bnxt_free_rx_rings(struct bnxt *bp) >> } >> } >> >> +static int bnxt_rx_agg_ring_fill_level(struct bnxt *bp, >> + struct bnxt_rx_ring_info *rxr) >> +{ >> + /* User may have chosen larger than default rx_page_size, >> + * we keep the ring sizes uniform and also want uniform amount >> + * of bytes consumed per ring, so cap how much of the rings we fill. >> + */ >> + int fill_level = bp->rx_agg_ring_size; >> + >> + if (rxr->rx_page_size > BNXT_RX_PAGE_SIZE) >> + fill_level /= rxr->rx_page_size / BNXT_RX_PAGE_SIZE; > > According to the check in bnxt_alloc_rx_page_pool() it's theoretically > possible for `rxr->rx_page_size / BNXT_RX_PAGE_SIZE` being zero. If so > the above would crash. > > Side note: this looks like something AI review could/should catch. The > fact it didn't makes me think I'm missing something... I doubt LLMs will be able to see it, but rx_page_size is no less than BNXT_RX_PAGE_SIZE. It's either set from defaults, which is exactly BNXT_RX_PAGE_SIZE, or given by the provider and then checked in bnxt_validate_qcfg(). -- Pavel Begunkov