Netdev List
 help / color / mirror / Atom feed
From: Javen <javen_xu@realsil.com.cn>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	顾晓军 <freddy_gu@realsil.com.cn>, "nb@tipi-net.de" <nb@tipi-net.de>,
	"maxime.chevallier@bootlin.com" <maxime.chevallier@bootlin.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"daniel@makrotopia.org" <daniel@makrotopia.org>,
	"vladimir.oltean@nxp.com" <vladimir.oltean@nxp.com>
Subject: RE: [PATCH net-next v1] net: phy: realtek: improve firmware write speed
Date: Fri, 11 Sep 2026 05:51:30 +0000	[thread overview]
Message-ID: <52ca9b2eddf24d5088124f1274d8cb17@realsil.com.cn> (raw)
In-Reply-To: <06862775-e6cb-425c-9118-d2571e8ab222@lunn.ch>

>
>On Thu, Sep 10, 2026 at 10:49:26AM +0800, javen wrote:
>> From: Javen Xu <javen_xu@realsil.com.cn>
>>
>> Firmware execution routine unconditionally uses phy_modify_mmd() for
>> all OP_WRITE entries which introduces an unnecessary read transaction
>> when updating an entire 16-bit register. So we optimize this by
>> checking bitmask boundaries. Use phy_write_mmd() directly to speed up
>> firmware loading process.
>
>For optimisations, it is normal to include some benchmark numbers to show
>how big a change it made. Is the added complexity worth the change?
>

I traced the actual MDC/MDIO hardware transactions during firmware loading process. Here are the benchmark numbers:

- Unpatched : about 28,000 MDIO transactions.
- Patched: about 9,600 MDIO transactions.

This results in a 65% reduction in MDIO traffic.

Thanks,
Javen

>        Andrew

  reply	other threads:[~2026-09-11  5:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10  2:49 [PATCH net-next v1] net: phy: realtek: improve firmware write speed javen
2026-09-10 12:25 ` Andrew Lunn
2026-09-11  5:51   ` Javen [this message]
2026-09-11  7:33     ` Nicolai Buchwitz
2026-09-11  9:38       ` Javen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52ca9b2eddf24d5088124f1274d8cb17@realsil.com.cn \
    --to=javen_xu@realsil.com.cn \
    --cc=andrew@lunn.ch \
    --cc=daniel@makrotopia.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=freddy_gu@realsil.com.cn \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maxime.chevallier@bootlin.com \
    --cc=nb@tipi-net.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox