From: Lars Melin <larsm17@gmail.com>
To: Kristian Evensen <kristian.evensen@gmail.com>,
Oliver Neukum <oneukum@suse.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling
Date: Tue, 19 Jul 2016 15:30:07 +0700 [thread overview]
Message-ID: <52d1cd85-8bdc-c8ed-7a2c-460cefe7f0d5@gmail.com> (raw)
In-Reply-To: <CAKfDRXjzgd58kS-MzUsZAsD66VCa5=qyqaLr_eZSm-XphxA7Mw@mail.gmail.com>
On 2016-07-19 13:40, Kristian Evensen wrote:
> I guess I can match on the VID/PID in usbnet, but won't it be cleaner
> to add a new bind() function (in cdc_ether) which matches the two PIDs
> and leave usbnet as is? Or am I misunderstanding how to add this
> functionality to usbnet?
>
Matching on the usb id is probably not a great idea, there is more id's
than the two you have found and there is also more than two non-unique
mac addresses.
Example:
0200FFAAAAAA 19d2:1589/1592/1595
020CE70B0102 19d2:1040/1048/1405
You can easily find them by googling them, without colon separators you
will find them in verbose lsusb listings, with colons you will find them
in dmesg pastings.
I would probably have found more dupes if users had refrained from using
the stupid usbdevices cmd which removes almost all interesting info from
device listings in internet foras.
/Lars
next prev parent reply other threads:[~2016-07-19 8:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 12:24 [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen
2016-07-18 13:01 ` Oliver Neukum
2016-07-18 13:23 ` Kristian Evensen
2016-07-18 13:50 ` Oliver Neukum
2016-07-18 14:10 ` Kristian Evensen
[not found] ` <CAKfDRXjaSz25_b8Na46DJEDvGUsZ-Xye+Rn2+o6Hy0EcuOopkA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-18 14:14 ` Oliver Neukum
2016-07-18 14:27 ` Kristian Evensen
[not found] ` <1468851242.2280.14.camel-IBi9RG/b67k@public.gmane.org>
2016-07-18 15:04 ` Kristian Evensen
[not found] ` <CAKfDRXiK82ULw7RnRGdFwzad8NOfnwZN0vqv=08Tf+cNSdyd2g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-19 6:20 ` Oliver Neukum
2016-07-19 6:40 ` Kristian Evensen
2016-07-19 7:17 ` Oliver Neukum
2016-07-19 8:30 ` Lars Melin [this message]
2016-07-19 11:06 ` Kristian Evensen
2016-08-08 12:44 ` Bjørn Mork
2016-08-08 13:57 ` Oliver Neukum
2016-08-08 18:30 ` Bjørn Mork
[not found] ` <87oa535d10.fsf-3F4PFWf5pNjpjLOzFPqGjWGXanvQGlWp@public.gmane.org>
2016-08-18 8:03 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52d1cd85-8bdc-c8ed-7a2c-460cefe7f0d5@gmail.com \
--to=larsm17@gmail.com \
--cc=kristian.evensen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).