From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ECA8C433FF for ; Tue, 13 Aug 2019 00:29:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A9172067D for ; Tue, 13 Aug 2019 00:29:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jXNRFNW0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726668AbfHMA3R (ORCPT ); Mon, 12 Aug 2019 20:29:17 -0400 Received: from mail-pf1-f181.google.com ([209.85.210.181]:37873 "EHLO mail-pf1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbfHMA3Q (ORCPT ); Mon, 12 Aug 2019 20:29:16 -0400 Received: by mail-pf1-f181.google.com with SMTP id 129so3635239pfa.4 for ; Mon, 12 Aug 2019 17:29:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=T8XbxlQrq0PnCGeDuc5tsfj1ZQ+e0M84noJSZpm/Nd0=; b=jXNRFNW03NvP5CG+eN0ZQAQeO8IL48piCRngdOc0OZyE2Xtsnjmnln1nQV8J+l0sxe /Rb47i4zD/aGCE6jKRNE/qBojKWy7CKlKsy8PaB60JtiQJ8YjD9vo0j10lLyTEAXf7ao H0JgcYZDnpd1t+zKzIt1BqOAGWaFElsPmGMhGuCbB7H2ClN4OfPUUKnFTt+yq2ISg34P kBxiBSfqbElBIpv8/3HcEahRPAJ1JoLLe2EJU64S4XEfdFix1vH/SVRAUQzYYYUA3Oiv rBc/wHwWnodTfwJkT/GUUd7+1Y45QPMUarZRJHk/hjXKUF2hLhPTjW1c07Jj/drprNoY mTTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=T8XbxlQrq0PnCGeDuc5tsfj1ZQ+e0M84noJSZpm/Nd0=; b=mofAJ5xuPeFI0JI9gLGKICxuVZm1oVk7y7dvlaH9BJG4uHFHoryyVOY4MPelHW2Jh+ 4URA8DlSfEqiiglq9w1zBLA7iqJo8kxf0uajMiRXrQN+3HpLE3dNXZ1pWm3ufLyRLjus KzCjeCBVR6lqfiXg1Ufsv6rio/dtPp16B5kcLpWLjy2jJzQc8Zh5PfRoWmq2fSZ4DVWS lg+pFAkQx/E0od092XouHW8bSJkiZzwqDd1AHrYNxOLHe8Ydw7X4MCCjaSpQgzyJqfOt KKIcXKF2M4+gkZ/KrcfXhdTnFQL8jd4hy0MFODX6OpUUPOWN3tJtzTcC7imNLQCb72e+ mr2w== X-Gm-Message-State: APjAAAVEv1e1X2gXYoYeIOqYhesQ85ONq60A2KXKcP35gvpwfbWn+JJC 0/sWlRFS/+lPPuSy+WKX9+U= X-Google-Smtp-Source: APXvYqzNFr0bCYm1OTuKAMxzJyHYhyB9bSddGrvxJqKyJhcRzS1IzIRPcPFaL/VoSWe4HTnf6/2b+A== X-Received: by 2002:a17:90a:bc06:: with SMTP id w6mr898541pjr.124.1565656156292; Mon, 12 Aug 2019 17:29:16 -0700 (PDT) Received: from [172.27.227.188] ([216.129.126.118]) by smtp.googlemail.com with ESMTPSA id j6sm761825pjd.19.2019.08.12.17.29.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Aug 2019 17:29:15 -0700 (PDT) Subject: Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames To: Jakub Kicinski , Roopa Prabhu Cc: Jiri Pirko , netdev , David Miller , Stephen Hemminger , dcbw@redhat.com, Michal Kubecek , Andrew Lunn , parav@mellanox.com, Saeed Mahameed , mlxsw References: <20190719110029.29466-1-jiri@resnulli.us> <20190719110029.29466-4-jiri@resnulli.us> <20190809062558.GA2344@nanopsycho.orion> <5e7270a1-8de6-1563-4e42-df37da161b98@gmail.com> <20190810063047.GC2344@nanopsycho.orion> <3b1e8952-e4c2-9be5-0b5c-d3ce4127cbe2@gmail.com> <20190812083139.GA2428@nanopsycho> <20190812144310.442869de@cakuba.netronome.com> From: David Ahern Message-ID: <52dd953a-d0c7-0086-5faa-18134f033c0b@gmail.com> Date: Mon, 12 Aug 2019 18:29:13 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190812144310.442869de@cakuba.netronome.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/12/19 3:43 PM, Jakub Kicinski wrote: > Is not adding commands better because it's easier to deal with the > RTM_NEWLINK notification? I must say it's unclear from the thread why > muxing the op through RTM_SETLINK is preferable. IMHO new op is > cleaner, do we have precedent for such IFLA_.*_OP-style attributes? An alternative name for a link is not a primary object; it is only an attribute of a link and links are manipulated through RTM_*LINK commands.