From: David Ahern <dsahern@kernel.org>
To: Ido Schimmel <idosch@nvidia.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, petrm@nvidia.com
Subject: Re: [PATCH net-next] nexthop: Simplify dump error handling
Date: Thu, 7 Mar 2024 12:28:32 -0700 [thread overview]
Message-ID: <52eea550-1179-42f4-a09d-083b2bda22a6@kernel.org> (raw)
In-Reply-To: <20240307154727.3555462-1-idosch@nvidia.com>
On 3/7/24 8:47 AM, Ido Schimmel wrote:
> The only error that can happen during a nexthop dump is insufficient
> space in the skb caring the netlink messages (EMSGSIZE). If this happens
> and some messages were already filled in, the nexthop code returns the
> skb length to signal the netlink core that more objects need to be
> dumped.
>
> After commit b5a899154aa9 ("netlink: handle EMSGSIZE errors in the
> core") there is no need to handle this error in the nexthop code as it
> is now handled in the core.
>
> Simplify the code and simply return the error to the core.
>
> No regressions in nexthop tests:
>
> # ./fib_nexthops.sh
> Tests passed: 234
> Tests failed: 0
>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
> net/ipv4/nexthop.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2024-03-07 19:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 15:47 [PATCH net-next] nexthop: Simplify dump error handling Ido Schimmel
2024-03-07 19:28 ` David Ahern [this message]
2024-03-08 21:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52eea550-1179-42f4-a09d-083b2bda22a6@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).