From: Roland Dreier <rolandd@cisco.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@vger.kernel.org, openib-general@openib.org
Subject: Re: Timeline of IPoIB performance
Date: Wed, 12 Oct 2005 09:53:57 -0700 [thread overview]
Message-ID: <52mzle7k2i.fsf@cisco.com> (raw)
In-Reply-To: <E1EPIxF-0001Cp-00@gondolin.me.apana.org.au> (Herbert Xu's message of "Tue, 11 Oct 2005 22:10:01 +1000")
Herbert> Try reverting the changeset
Herbert> 314324121f9b94b2ca657a494cf2b9cb0e4a28cc
Herbert> which lies between these two points and may be relevant.
Matt, I pulled this out of git for you. I guess Herbert is suggesting
to patch -R the below against 2.6.12-rc5:
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 79835a6..5bad504 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -4355,16 +4355,7 @@ int tcp_rcv_established(struct sock *sk,
goto no_ack;
}
- if (eaten) {
- if (tcp_in_quickack_mode(tp)) {
- tcp_send_ack(sk);
- } else {
- tcp_send_delayed_ack(sk);
- }
- } else {
- __tcp_ack_snd_check(sk, 0);
- }
-
+ __tcp_ack_snd_check(sk, 0);
no_ack:
if (eaten)
__kfree_skb(skb);
next parent reply other threads:[~2005-10-12 16:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1EPIxF-0001Cp-00@gondolin.me.apana.org.au>
2005-10-12 16:53 ` Roland Dreier [this message]
2005-10-12 18:28 ` Timeline of IPoIB performance Matt Leininger
2005-10-13 1:24 ` Matt Leininger
2005-10-13 1:48 ` Herbert Xu
[not found] <1128672413.13948.326.camel@localhost>
[not found] ` <52br20lsei.fsf@cisco.com>
2005-10-08 2:25 ` Matt Leininger
2005-10-10 18:23 ` Roland Dreier
2005-10-10 20:03 ` Michael S. Tsirkin
2005-10-10 21:03 ` Roland Dreier
2005-10-10 20:17 ` Rick Jones
2005-10-10 20:58 ` Roland Dreier
2005-10-10 21:22 ` Rick Jones
2005-10-10 21:26 ` Grant Grundler
2005-10-10 23:30 ` Grant Grundler
2005-10-11 0:51 ` Andi Kleen
2005-10-10 23:25 ` Matt Leininger
2005-10-10 23:38 ` Roland Dreier
2005-10-10 23:44 ` Matt Leininger
2005-10-10 23:53 ` Roland Dreier
2005-10-11 4:03 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52mzle7k2i.fsf@cisco.com \
--to=rolandd@cisco.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=openib-general@openib.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).