[PATCH] netdevice.h: Add RDMA private pointer to the net_device structure

[PATCH] netdevice.h: Add RDMA private pointer to the net_device structure

[Hal Rosenstock]

netdevice.h: Add RDMA private pointer to the net_device structure

Signed-off-by: Hal Rosenstock <halr@voltaire.com>

--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -366,6 +366,7 @@ struct net_device
        void                    *ip6_ptr;       /* IPv6 specific data */
        void                    *ec_ptr;        /* Econet specific data */
        void                    *ax25_ptr;      /* AX.25 specific data */
+       void                    *rdma_ptr;      /* RDMA specific data */
 
 /*
  * Cache line mostly used on receive path (including eth_type_trans())

Re: [PATCH] netdevice.h: Add RDMA private pointer to the net_device structure

[Stephen Hemminger]

On 03 Oct 2005 14:48:44 -0400
Hal Rosenstock <halr@voltaire.com> wrote:

> netdevice.h: Add RDMA private pointer to the net_device structure
> 
> Signed-off-by: Hal Rosenstock <halr@voltaire.com>

Who is going to use it? Is RDMA being submitted for code review?

-- 
Stephen Hemminger <shemminger@osdl.org>
OSDL http://developer.osdl.org/~shemminger

Re: [PATCH] netdevice.h: Add RDMA private pointer to the net_device structure

[Hal Rosenstock]

On Mon, 2005-10-03 at 16:54, Stephen Hemminger wrote:
> On 03 Oct 2005 14:48:44 -0400
> Hal Rosenstock <halr@voltaire.com> wrote:
> 
> > netdevice.h: Add RDMA private pointer to the net_device structure
> > 
> > Signed-off-by: Hal Rosenstock <halr@voltaire.com>
> 
> Who is going to use it? Is RDMA being submitted for code review?

IB (and ultimately RDMA) will use it.

-- Hal

Re: Re: [PATCH] netdevice.h: Add RDMA private pointer to the net_device structure

[Roland Dreier]

    Stephen> Who is going to use it? Is RDMA being submitted for code
    Stephen> review?

I agree that we should hold off on this until there's an in-tree user.
However, just as a clarification, we're trying to move from "ib" to
"rdma" nomenclature as we try to make the existing kernel InfiniBand
layer a more generic layer than can support both IB and iWARP.  So new
code should use "rdma" names.

 - R.

Re: [PATCH] netdevice.h: Add RDMA private pointer to the net_device structure

[Roland Dreier]

    Hal> netdevice.h: Add RDMA private pointer to the net_device structure

I don't think there's any point in making this change until we have
some code that will use the pointer.

 - R.

Re: [PATCH] netdevice.h: Add RDMA private pointer to the net_device structure

[Hal Rosenstock]

On Mon, 2005-10-03 at 17:29, Roland Dreier wrote:
>     Hal> netdevice.h: Add RDMA private pointer to the net_device structure
> 
> I don't think there's any point in making this change until we have
> some code that will use the pointer.

We will have this shortly. I have been waiting for this to propose the
changes to SDP et al.

-- Hal

Re: [PATCH] netdevice.h: Add RDMA private pointer to the net_device structure

[Roland Dreier]

    Hal> We will have this shortly. I have been waiting for this to
    Hal> propose the changes to SDP et al.

OK, but I don't think it makes sense to merge this upstream until
there is in-tree code that will use it.

 - R.

Re: [PATCH] netdevice.h: Add RDMA private pointer to the net_device structure

[Hal Rosenstock]

On Mon, 2005-10-03 at 17:35, Roland Dreier wrote:
>     Hal> We will have this shortly. I have been waiting for this to
>     Hal> propose the changes to SDP et al.
> 
> OK, but I don't think it makes sense to merge this upstream until
> there is in-tree code that will use it.

I wanted to get this in so I could add the code to IPoIB to use this so SDP
and others no longer poke at IPoIB's private data. This is a small
change. Should this change be made locally (in OpenIB) first (and we'll
have our own modified netdevice.h for a short time) ?

-- Hal

Re: [PATCH] netdevice.h: Add RDMA private pointer to the net_device structure

[Roland Dreier]

    Hal> I wanted to get this in so I could add the code to IPoIB to
    Hal> use this so SDP and others no longer poke at IPoIB's private
    Hal> data. This is a small change. Should this change be made
    Hal> locally (in OpenIB) first (and we'll have our own modified
    Hal> netdevice.h for a short time) ?

Yes, I think that's the way to develop this sort of thing.

 - R.

Re: [PATCH] netdevice.h: Add RDMA private pointer to the net_device structure

[David S. Miller]

From: Roland Dreier <rolandd@cisco.com>
Date: Mon, 03 Oct 2005 14:29:08 -0700

>     Hal> netdevice.h: Add RDMA private pointer to the net_device structure
> 
> I don't think there's any point in making this change until we have
> some code that will use the pointer.

I definitely agree.