From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net
Subject: Re: [net-next 1/3] net: bcmgenet: drop checks on priv->phydev
Date: Fri, 21 Feb 2014 02:54:05 +0300 [thread overview]
Message-ID: <5306959D.5070101@cogentembedded.com> (raw)
In-Reply-To: <1392929631-7685-2-git-send-email-f.fainelli@gmail.com>
Hello.
On 02/20/2014 11:53 PM, Florian Fainelli wrote:
> Drop all the checks on priv->phydev since we will refuse probing the
> driver if we cannot attach to a PHY device. Drop all checks on
> priv->phydev. This also fixes some smatch issues reported by Dan
> Carpenter where smatch would complain that a pointer is not always
> checked correctly.
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/net/ethernet/broadcom/genet/bcmgenet.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index 0ebc297..8af5f07 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
[...]
> @@ -1811,8 +1810,7 @@ static void bcmgenet_irq_task(struct work_struct *work)
> /* Link UP/DOWN event */
> if ((priv->hw_params->flags & GENET_HAS_MDIO_INTR) &&
> (priv->irq0_stat & (UMAC_IRQ_LINK_UP|UMAC_IRQ_LINK_DOWN))) {
> - if (priv->phydev)
> - phy_mac_interrupt(priv->phydev,
> + phy_mac_interrupt(priv->phydev,
> (priv->irq0_stat & UMAC_IRQ_LINK_UP));
Should probably realign this line (although it wasn't correctly aligned
before). Also () are not needed around &.
WBR, Sergei
next prev parent reply other threads:[~2014-02-20 22:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 20:53 [net-next 0/3] net: bcmgenet: warnings fixes Florian Fainelli
2014-02-20 20:53 ` [net-next 1/3] net: bcmgenet: drop checks on priv->phydev Florian Fainelli
2014-02-20 23:54 ` Sergei Shtylyov [this message]
2014-02-20 20:53 ` [net-next 2/3] net: bcmgenet: fix warning on ndo_select_queue Florian Fainelli
2014-02-20 20:53 ` [net-next 3/3] net: bcmgenet: remove commented code in bcmgenet_xmit() Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5306959D.5070101@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).