From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 2/4] net: rfkill: gpio: remove gpio names Date: Thu, 20 Feb 2014 22:35:21 -0700 Message-ID: <5306E599.7020605@wwwdotorg.org> References: <1392900697-27577-1-git-send-email-heikki.krogerus@linux.intel.com> <1392900697-27577-3-git-send-email-heikki.krogerus@linux.intel.com> <53062F97.3050407@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Heikki Krogerus , Johannes Berg , "David S. Miller" , Rhyland Klein , linux-wireless , netdev , linux-kernel , Arnd Bergmann , Linus Walleij , Alexandre Courbot To: Chen-Yu Tsai Return-path: In-Reply-To: Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On 02/20/2014 06:55 PM, Chen-Yu Tsai wrote: > Hi, > > On Fri, Feb 21, 2014 at 12:38 AM, Stephen Warren wrote: >> On 02/20/2014 05:51 AM, Heikki Krogerus wrote: >>> There is no use for them in this driver. This will fix a >>> static checker warning.. >> >> Didn't you remove the use: >> >> - gpio = devm_gpiod_get_index(&pdev->dev, rfkill->reset_name, 0); >> + gpio = devm_gpiod_get_index(&pdev->dev, NULL, 0); >> >> doesn't that parameter get put into the sysfs GPIO debug file, so people >> can see which GPIOs are used for what? > > That's correct. However using con_id to pass this results in different > behavior across DT and ACPI. A better way is to export the labeling > function so consumers can set meaningful labels themselves. But this code is the consumer of those GPIOs. IF the parameter to devm_gpiod_get_index() isn't intended to be used, why does it exist? -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html