netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] ip_tunnel:multicast process cause panic due to skb->_skb_refdst NULL pointer
@ 2014-02-22  8:43 lucien
  0 siblings, 0 replies; only message in thread
From: lucien @ 2014-02-22  8:43 UTC (permalink / raw)
  To: netdev; +Cc: davem, kuznet, jmorris, yoshfuji, kaber

when ip_tunnel process multicast packets, it may check if the packet is
looped back packet though 'rt_is_output_route(skb_rtable(skb))' in
ip_tunnel_rcv(), but before that , skb->_skb_refdst has been dropped in
iptunnel_pull_header(), so which leads to a panic.

fix the bug: https://bugzilla.kernel.org/show_bug.cgi?id=70681

diff --git a/net/ipv4/ip_tunnel_core.c b/net/ipv4/ip_tunnel_core.c
index 6156f4e..88b08aa 100644
--- a/net/ipv4/ip_tunnel_core.c
+++ b/net/ipv4/ip_tunnel_core.c
@@ -108,7 +108,6 @@ int iptunnel_pull_header(struct sk_buff *skb, int 
hdr_len, __be16 inner_proto)
         nf_reset(skb);
         secpath_reset(skb);
         skb_clear_hash_if_not_l4(skb);
-       skb_dst_drop(skb);
         skb->vlan_tci = 0;
         skb_set_queue_mapping(skb, 0);
         skb->pkt_type = PACKET_HOST;

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2014-02-22  8:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-22  8:43 [PATCH net-next] ip_tunnel:multicast process cause panic due to skb->_skb_refdst NULL pointer lucien

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).